Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

update opened_burn_account comments, propagate errors, and lower the log level (#3806)

Browse source
This commit is contained in:
Rachel Franks 2022-05-04 15:53:55 -05:00 • committed by GitHub
commit 07662aae22
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
nano/lib/errors.cpp
View file

@ -251,7 +251,7 @@ std::string nano::error_process_messages::message (int ev) const
case nano::error_process::gap_epoch_open_pending:
return "Gap pending for open epoch block";
case nano::error_process::opened_burn_account:
return "Burning account";
return "Block attempts to open the burn account";
case nano::error_process::balance_mismatch:
return "Balance and amount delta do not match";
case nano::error_process::block_position:

2
nano/lib/errors.hpp
View file

@ -138,7 +138,7 @@ enum class error_process
gap_previous, // Block marked as previous is unknown
gap_source, // Block marked as source is unknown
gap_epoch_open_pending, // Block marked as pending blocks required for epoch open block are unknown
opened_burn_account, // The impossible happened, someone found the private key associated with the public key '0'.
opened_burn_account, // Block attempts to open the burn account
balance_mismatch, // Balance and amount delta don't match
block_position, // This block cannot follow the previous block
insufficient_work, // Insufficient work for this block, even though it passed the minimal validation

5
nano/node/blockprocessor.cpp
View file

@ -455,7 +455,10 @@ nano::process_return nano::block_processor::process_one (nano::write_transaction
}
case nano::process_result::opened_burn_account:
{
node.logger.always_log (boost::str (boost::format ("*** Rejecting open block for burn account ***: %1%") % hash.to_string ()));
if (node.config.logging.ledger_logging ())
{
node.logger.try_log (boost::str (boost::format ("Rejecting open block for burn account: %1%") % hash.to_string ()));
}
break;
}
case nano::process_result::balance_mismatch:

3
nano/node/json_handler.cpp
View file

@ -3312,6 +3312,9 @@ void nano::json_handler::process ()
rpc_l->ec = nano::error_process::insufficient_work;
break;
}
case nano::process_result::opened_burn_account:
rpc_l->ec = nano::error_process::opened_burn_account;
break;
default:
{
rpc_l->ec = nano::error_process::other;

2
nano/secure/common.hpp
View file

@ -339,7 +339,7 @@ enum class process_result
gap_previous, // Block marked as previous is unknown
gap_source, // Block marked as source is unknown
gap_epoch_open_pending, // Block marked as pending blocks required for epoch open block are unknown
opened_burn_account, // The impossible happened, someone found the private key associated with the public key '0'.
opened_burn_account, // Block attempts to open the burn account
balance_mismatch, // Balance and amount delta don't match
representative_mismatch, // Representative is changed when it is not allowed
block_position, // This block cannot follow the previous block