Fix intermittent failure in active_transactions.confirmation_consistency (#2682)

* Fix intermittent failure in active_transactions.confirmation_consistency

`recently_cemented` is only changed in the conf height observer callbacks. This is the intended behavior, but the test was intermittently failing under TSAN.

* Empty commit
This commit is contained in:
Guilherme Lawless 2020-03-26 17:48:51 +00:00 committed by GitHub
commit 142996cdbe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -851,7 +851,7 @@ TEST (active_transactions, confirmation_consistency)
nano::lock_guard<std::mutex> guard (node.active.mutex);
ASSERT_EQ (i + 1, node.active.recently_confirmed.size ());
ASSERT_EQ (block->qualified_root (), node.active.recently_confirmed.back ().first);
ASSERT_EQ (i + 1, node.active.recently_cemented.size ());
ASSERT_TIMELY (1s, i + 1 == node.active.recently_cemented.size ()); // done after a callback
}
}
}