From 20e055882783db5fea52d9c64e2503f8bf8a054a Mon Sep 17 00:00:00 2001 From: clemahieu Date: Mon, 29 May 2017 17:58:50 -0500 Subject: [PATCH] Fixing uninitialized variables found with valgrind. --- rai/core_test/node.cpp | 9 +++++++++ rai/node/node.cpp | 3 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/rai/core_test/node.cpp b/rai/core_test/node.cpp index 07e0b979..631dcb76 100644 --- a/rai/core_test/node.cpp +++ b/rai/core_test/node.cpp @@ -477,6 +477,9 @@ TEST (node_config, serialization) config1.inactive_supply = 10; config1.password_fanout = 10; config1.enable_voting = false; + config1.callback_address = "test"; + config1.callback_port = 10; + config1.callback_target = "test"; boost::property_tree::ptree tree; config1.serialize_json (tree); rai::logging logging2 (path); @@ -488,6 +491,9 @@ TEST (node_config, serialization) ASSERT_NE (config2.inactive_supply, config1.inactive_supply); ASSERT_NE (config2.password_fanout, config1.password_fanout); ASSERT_NE (config2.enable_voting, config1.enable_voting); + ASSERT_NE (config2.callback_address, config1.callback_address); + ASSERT_NE (config2.callback_port, config1.callback_port); + ASSERT_NE (config2.callback_target, config1.callback_target); bool upgraded (false); config2.deserialize_json (upgraded, tree); @@ -498,6 +504,9 @@ TEST (node_config, serialization) ASSERT_EQ (config2.inactive_supply, config1.inactive_supply); ASSERT_EQ (config2.password_fanout, config1.password_fanout); ASSERT_EQ (config2.enable_voting, config1.enable_voting); + ASSERT_EQ (config2.callback_address, config1.callback_address); + ASSERT_EQ (config2.callback_port, config1.callback_port); + ASSERT_EQ (config2.callback_target, config1.callback_target); } TEST (node_config, v1_v2_upgrade) diff --git a/rai/node/node.cpp b/rai/node/node.cpp index 3ef2cd8a..b1c461df 100755 --- a/rai/node/node.cpp +++ b/rai/node/node.cpp @@ -728,7 +728,8 @@ password_fanout (1024), io_threads (std::max (4, std::thread::hardware_concurrency ())), work_threads (std::max (4, std::thread::hardware_concurrency ())), enable_voting (true), -bootstrap_connections (16) +bootstrap_connections (16), +callback_port (0) { switch (rai::rai_network) {