Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix for unit test unchecked.multiple_get, do not use store.count() (#3738)

Browse source 
When using rocksdb as the backend database, the count() method of the
store cannot be trusted, it does not give accurate results.

This problem is fixed by counting the blocks in the unchecked table
one by one, by iterating through all of them, which should work for all
db backends.

resolves #3737
This commit is contained in:
Dimitrios Siganos 2022-02-15 13:51:12 +00:00 • committed by GitHub
commit 26d81b1fdb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
nano/core_test/block_store.cpp
View file

@ -459,8 +459,22 @@ TEST (unchecked, multiple_get)
unchecked.put (block3->previous (), block3);
unchecked.put (block3->hash (), block3); // unchecked4
unchecked.put (block1->previous (), block3); // unchecked1
// count the number of blocks in the unchecked table by counting them one by one
// we cannot trust the count() method if the backend is rocksdb
auto count_unchecked_blocks_one_by_one = [&store, &unchecked] () {
size_t count = 0;
auto transaction = store->tx_begin_read ();
for (auto [i, end] = unchecked.full_range (transaction); i != end; ++i)
{
++count;
}
return count;
};
// Waits for the blocks to get saved in the database
ASSERT_TIMELY (5s, 8 == unchecked.count (store->tx_begin_read ()));
ASSERT_TIMELY (5s, 8 == count_unchecked_blocks_one_by_one ());
std::vector<nano::block_hash> unchecked1;
// Asserts the entries will be found for the provided key
auto transaction = store->tx_begin_read ();