Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Only update timestamp when sampling is enabled as this has a performance impact

Browse source
This commit is contained in:
Colin LeMahieu 2023-08-30 17:03:35 +01:00
commit 38ea6b629a
No known key found for this signature in database
GPG key ID: 43708520C8DFB938
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
nano/lib/stats.cpp
View file

@ -395,18 +395,17 @@ void nano::stats::update (uint32_t key_a, uint64_t value)
if (!stopped)
{
auto entry (get_entry_impl (key_a, config.interval, config.capacity));
// Counters
auto old (entry->counter.get_value ());
entry->counter.add (value);
entry->count_observers.notify (old, entry->counter.get_value ());
auto has_interval_counter = [&] () {
return config.log_interval_counters > 0;
};
auto has_sampling = [&] () {
return config.sampling_enabled && entry->sample_interval > 0;
};
// Counters
auto old (entry->counter.get_value ());
entry->counter.add (value, has_sampling ()); // Only update timestamp when sampling is enabled as this has a performance impact
entry->count_observers.notify (old, entry->counter.get_value ());
if (has_interval_counter () || has_sampling ())
{
auto now = std::chrono::steady_clock::now (); // Only sample clock if necessary as this impacts node performance due to frequent usage