From 42544be68ee053909ca0d1de70d9bfc224d34917 Mon Sep 17 00:00:00 2001
From: Dimitrios Siganos <dimitris@siganos.org>
Date: Tue, 5 Mar 2024 18:34:20 +0000
Subject: [PATCH] Do not return node_id private key in RPC call (#4459)

It could become a problem one day.
This is breaking a debug API, that nobody should be using for serious tasks. So it should not cause any problems.
---
 nano/node/json_handler.cpp | 1 -
 nano/rpc_test/rpc.cpp      | 1 -
 2 files changed, 2 deletions(-)

diff --git a/nano/node/json_handler.cpp b/nano/node/json_handler.cpp
index 3ef09287..ec02593e 100644
--- a/nano/node/json_handler.cpp
+++ b/nano/node/json_handler.cpp
@@ -2922,7 +2922,6 @@ void nano::json_handler::node_id ()
 {
 	if (!ec)
 	{
-		response_l.put ("private", node.node_id.prv.to_string ());
 		response_l.put ("public", node.node_id.pub.to_string ());
 		response_l.put ("as_account", node.node_id.pub.to_account ());
 		response_l.put ("node_id", node.node_id.pub.to_node_id ());
diff --git a/nano/rpc_test/rpc.cpp b/nano/rpc_test/rpc.cpp
index 6dc67ff2..da0b1af1 100644
--- a/nano/rpc_test/rpc.cpp
+++ b/nano/rpc_test/rpc.cpp
@@ -5406,7 +5406,6 @@ TEST (rpc, node_id)
 	boost::property_tree::ptree request;
 	request.put ("action", "node_id");
 	auto response (wait_response (system, rpc_ctx, request));
-	ASSERT_EQ (node->node_id.prv.to_string (), response.get<std::string> ("private"));
 	ASSERT_EQ (node->node_id.pub.to_account (), response.get<std::string> ("as_account"));
 	ASSERT_EQ (node->node_id.pub.to_node_id (), response.get<std::string> ("node_id"));
 }