Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Erase representatives with full queues when adding to confirmation solicitor (#2649)

Browse source 
With this change less processing happens for elections that won't fit in the solicitor.
This commit is contained in:
Guilherme Lawless 2020-03-12 09:07:12 +00:00 • committed by GitHub
commit 54761e42bf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
nano/node/confirmation_solicitor.cpp
View file

@ -37,8 +37,9 @@ bool nano::confirmation_solicitor::add (nano::election const & election_a)
debug_assert (prepared);
auto const max_channel_requests (max_confirm_req_batches * nano::network::confirm_req_hashes_max);
unsigned count = 0;
for (auto i (representatives.begin ()), n (representatives.end ()); i != n && count < max_election_requests; ++i)
for (auto i (representatives.begin ()); i != representatives.end () && count < max_election_requests;)
{
bool full_queue (false);
auto rep (*i);
if (election_a.last_votes.find (rep.account) == election_a.last_votes.end ())
{
@ -48,7 +49,12 @@ bool nano::confirmation_solicitor::add (nano::election const & election_a)
request_queue.emplace_back (election_a.status.winner->hash (), election_a.status.winner->root ());
++count;
}
else
{
full_queue = true;
}
}
i = !full_queue ? i + 1 : representatives.erase (i);
}
return count == 0;
}