Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix for test active_transactions.fork_filter_cleanup (#3775)

Browse source 
The publish filter and the ledger cache count are not synchronised and
therefore the last assert needs to be an assert timely.

resolves #3762
This commit is contained in:
Dimitrios Siganos 2022-04-02 13:44:43 +01:00 • committed by GitHub
commit 6397a44fc0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
nano/core_test/active_transactions.cpp
View file

@ -767,6 +767,9 @@ TEST (active_transactions, fork_filter_cleanup)
}
// All forks were merged into the same election
std::shared_ptr<nano::election> election{};
ASSERT_TIMELY (5s, (election = node1.active.election (send1->qualified_root ())) != nullptr);
ASSERT_TIMELY (5s, election->blocks ().size () == 10);
ASSERT_EQ (1, node1.active.size ());
// Instantiate a new node
@ -787,11 +790,7 @@ TEST (active_transactions, fork_filter_cleanup)
ASSERT_TIMELY (5s, node1.ledger.cache.block_count == 2);
// Block is erased from the duplicate filter
ASSERT_FALSE (node1.network.publish_filter.apply (send_block_bytes.data (), send_block_bytes.size ()));
std::shared_ptr<nano::election> election{};
ASSERT_TIMELY (5s, (election = node1.active.election (send1->qualified_root ())) != nullptr);
ASSERT_TIMELY (5s, election->blocks ().size () == 10);
ASSERT_TIMELY (5s, node1.network.publish_filter.apply (send_block_bytes.data (), send_block_bytes.size ()));
}
TEST (active_transactions, fork_replacement_tally)