Some minor clang static analysis fixes (#2495)

nano/core_test/fakes/work_peer.hpp

@@ -212,7 +212,8 @@ private:
 	void listen ()
 	{
 		std::weak_ptr<fake_work_peer> this_w (shared_from_this ());
-		auto connection (std::make_shared<work_peer_connection> (ioc, type, pool,
+		auto connection (std::make_shared<work_peer_connection> (
+		ioc, type, pool,
 		[this_w](bool const good_generation) {
 			if (auto this_l = this_w.lock ())
 			{

nano/node/active_transactions.cpp

@@ -14,8 +14,8 @@ nano::active_transactions::active_transactions (nano::node & node_a) :
 node (node_a),
 multipliers_cb (20, 1.),
 trended_active_difficulty (node_a.network_params.network.publish_threshold),
-next_frontier_check (steady_clock::now ()),
 solicitor (node_a.network, node_a.network_params.network),
+next_frontier_check (steady_clock::now ()),
 long_election_threshold (node_a.network_params.network.is_test_network () ? 2s : 24s),
 election_request_delay (node_a.network_params.network.is_test_network () ? 0s : 1s),
 election_time_to_live (node_a.network_params.network.is_test_network () ? 0s : 10s),

nano/node/node.cpp

@@ -132,7 +132,6 @@ port_mapping (*this),
 vote_processor (checker, active, store, observers, stats, config, logger, online_reps, ledger, network_params),
 rep_crawler (*this),
 warmed_up (0),
-votes_cache (wallets),
 block_processor (*this, write_database_queue),
 // clang-format off
 block_processor_thread ([this]() {
@@ -141,6 +140,7 @@ block_processor_thread ([this]() {
 }),
 // clang-format on
 online_reps (ledger, network_params, config.online_weight_minimum.number ()),
+votes_cache (wallets),
 vote_uniquer (block_uniquer),
 active (*this),
 aggregator (stats, network_params.network, votes_cache, store, wallets),