Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Converting upgrade logging message that was writing to cerr to a standard always_log message. We don't log error messages to cerr so this was out of place.

Browse source 
Removing an unnecessary check for vacuuming within unit tests. This would be functionally equivalent yet potentially a performance issue. Timing the unit tests showed < 1% difference in time.
This commit is contained in:
clemahieu 2021-08-08 16:53:24 +01:00
commit 7520bbe8c7
No known key found for this signature in database
GPG key ID: 43708520C8DFB938
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
nano/node/lmdb/lmdb.cpp
View file

@ -93,13 +93,9 @@ nano::mdb_store::mdb_store (nano::logger_mt & logger_a, boost::filesystem::path
// (can be a few minutes with the --fast_bootstrap flag for instance)
if (!is_fully_upgraded)
{
nano::network_constants network_constants;
if (!is_fresh_db)
{
if (!network_constants.is_dev_network ())
{
std::cout << "Upgrade in progress..." << std::endl;
}
logger.always_log ("Upgrade in progress...");
if (backup_before_upgrade_a)
{
create_backup_file (env, path_a, logger_a);
@ -115,7 +111,7 @@ nano::mdb_store::mdb_store (nano::logger_mt & logger_a, boost::filesystem::path
}
}
if (needs_vacuuming && !network_constants.is_dev_network ())
if (needs_vacuuming)
{
logger.always_log ("Preparing vacuum...");
auto vacuum_success = vacuum_after_upgrade (path_a, lmdb_config_a);