From 7976d310ebcb53bd113821bd41caec5fa055374f Mon Sep 17 00:00:00 2001 From: Dimitrios Siganos Date: Wed, 10 Apr 2024 12:59:15 +0900 Subject: [PATCH] Bugfix add_outer_node, it should be added to disconnected set of nodes By adding it to the standard set of nodes, any sebsequent node additions will connect to it and it is will remain unconnected. add_outer_node should be merged with make_disconnected_node. --- nano/test_common/network.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/nano/test_common/network.cpp b/nano/test_common/network.cpp index 5ca9bcf4..bb37ff12 100644 --- a/nano/test_common/network.cpp +++ b/nano/test_common/network.cpp @@ -24,19 +24,21 @@ std::shared_ptr nano::test::establish_tcp (nano::t return result; } +// TODO: merge with make_disconnected_node std::shared_ptr nano::test::add_outer_node (nano::test::system & system_a, nano::node_config const & config_a, nano::node_flags flags_a) { auto outer_node = std::make_shared (system_a.io_ctx, nano::unique_path (), config_a, system_a.work, flags_a); outer_node->start (); - system_a.nodes.push_back (outer_node); + system_a.disconnected_nodes.push_back (outer_node); return outer_node; } +// TODO: merge with make_disconnected_node std::shared_ptr nano::test::add_outer_node (nano::test::system & system_a, nano::node_flags flags_a) { auto outer_node = std::make_shared (system_a.io_ctx, system_a.get_available_port (), nano::unique_path (), system_a.work, flags_a); outer_node->start (); - system_a.nodes.push_back (outer_node); + system_a.disconnected_nodes.push_back (outer_node); return outer_node; }