From 8d08259cbb656db4a538d4076178151381df7b30 Mon Sep 17 00:00:00 2001 From: Dimitrios Siganos Date: Mon, 19 Feb 2024 01:34:19 +0000 Subject: [PATCH] Re-enable unit test active_transactions.confirm_new (#4438) I am renabling this test. It is a trivial test and I can see no reason why it should not work. If it does not work, then we need to find out why. --- nano/core_test/active_transactions.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/nano/core_test/active_transactions.cpp b/nano/core_test/active_transactions.cpp index c848ffe2..dc59f954 100644 --- a/nano/core_test/active_transactions.cpp +++ b/nano/core_test/active_transactions.cpp @@ -1041,10 +1041,7 @@ TEST (active_transactions, confirmation_consistency) } } -// Test disabled because it's failing intermittently. -// PR in which it got disabled: https://github.com/nanocurrency/nano-node/pull/3629 -// Issue for investigating it: https://github.com/nanocurrency/nano-node/issues/3634 -TEST (active_transactions, DISABLED_confirm_new) +TEST (active_transactions, confirm_new) { nano::test::system system (1); auto & node1 = *system.nodes[0]; @@ -1063,7 +1060,8 @@ TEST (active_transactions, DISABLED_confirm_new) // Let node2 know about the block ASSERT_TIMELY (5s, node2.block (send->hash ())); // Wait confirmation - ASSERT_TIMELY (5s, node1.ledger.cache.cemented_count == 2 && node2.ledger.cache.cemented_count == 2); + ASSERT_TIMELY (5s, node1.ledger.cache.cemented_count == 2); + ASSERT_TIMELY (5s, node2.ledger.cache.cemented_count == 2); } // Ensures votes are tallied on election::publish even if no vote is inserted through inactive_votes_cache