From 8ffbcaca5c59fa60e1889976d855112a6d8dadd2 Mon Sep 17 00:00:00 2001 From: clemahieu Date: Thu, 19 Jan 2023 08:39:37 +0000 Subject: [PATCH] Stop must be called within ~backlog_population. If the system is destroyed and nodes have not been explicitly stopped, for instance in a test case failure, this would leave the backlog thread running. --- nano/node/backlog_population.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/nano/node/backlog_population.cpp b/nano/node/backlog_population.cpp index 896db725..dc4a8483 100644 --- a/nano/node/backlog_population.cpp +++ b/nano/node/backlog_population.cpp @@ -13,6 +13,7 @@ nano::backlog_population::backlog_population (const config & config_a, nano::sto nano::backlog_population::~backlog_population () { + stop (); // Thread must be stopped before destruction debug_assert (!thread.joinable ()); }