From 91816197ca1b8736fefd8a9ace64132238fb22a5 Mon Sep 17 00:00:00 2001
From: clemahieu <clemahieu@gmail.com>
Date: Mon, 25 Dec 2017 16:46:46 -0600
Subject: [PATCH] Requeueing pull inside bootstrap block_processor lambda
 because that doesn't require extra functions or locking on
 bootstrap_initiator. This also has less complicated locking.

Logging when we're flushing blocks.
---
 rai/node/bootstrap.cpp | 37 ++++++++++++++-----------------------
 rai/node/bootstrap.hpp |  1 -
 rai/node/node.cpp      |  1 -
 3 files changed, 14 insertions(+), 25 deletions(-)

diff --git a/rai/node/bootstrap.cpp b/rai/node/bootstrap.cpp
index c38e85de..22042f4e 100755
--- a/rai/node/bootstrap.cpp
+++ b/rai/node/bootstrap.cpp
@@ -592,7 +592,8 @@ void rai::bulk_pull_client::received_block (boost::system::error_code const & ec
 				expected = block->previous ();
 			}
 			auto attempt_l (connection->attempt);
-			attempt_l->node->block_processor.add (rai::block_processor_item (block, [attempt_l] (MDB_txn * transaction_a, rai::process_return result_a, std::shared_ptr <rai::block> block_a)
+			auto pull_l (pull);
+			attempt_l->node->block_processor.add (rai::block_processor_item (block, [attempt_l, pull_l] (MDB_txn * transaction_a, rai::process_return result_a, std::shared_ptr <rai::block> block_a)
 			{
 				switch (result_a.code)
 				{
@@ -606,6 +607,8 @@ void rai::bulk_pull_client::received_block (boost::system::error_code const & ec
 						node_l->active.start (transaction_a, block);
 						node_l->network.broadcast_confirm_req (block_a);
 						node_l->network.broadcast_confirm_req (block);
+						auto hash (block_a->hash ());
+						attempt_l->requeue_pull (rai::pull_info (pull_l.account, hash, hash));
 						BOOST_LOG (node_l->log) << boost::str (boost::format ("Fork received in bootstrap between: %1% and %2% root %3%") % block_a->hash ().to_string () % block->hash ().to_string () % block_a->root ().to_string ());
 						break;
 					}
@@ -891,7 +894,9 @@ void rai::bootstrap_attempt::run ()
 			}
 		}
 		// Flushing may resolve forks which can add more pulls
+		BOOST_LOG (node->log) << "Flushing unchecked blocks";
 		node->block_processor.flush ();
+		BOOST_LOG (node->log) << "Finished flushing unchecked blocks";
 	}
 	if (!stopped)
 	{
@@ -1041,7 +1046,7 @@ stopped (false)
 
 rai::bootstrap_initiator::~bootstrap_initiator ()
 {
-    stop ();
+	stop ();
 }
 
 void rai::bootstrap_initiator::bootstrap ()
@@ -1049,26 +1054,26 @@ void rai::bootstrap_initiator::bootstrap ()
 	std::unique_lock <std::mutex> lock (mutex);
 	if (!stopped && attempt == nullptr)
 	{
-        stop_attempt (lock);
-        attempt = std::make_shared <rai::bootstrap_attempt> (node.shared ());
+		stop_attempt (lock);
+		attempt = std::make_shared <rai::bootstrap_attempt> (node.shared ());
 		attempt_thread.reset (new std::thread ([this] ()
-        {
-            attempt->run ();
+		{
+			attempt->run ();
 			std::lock_guard <std::mutex> lock (mutex);
 			attempt.reset ();
 			condition.notify_all ();
-        }));
+		}));
 	}
 }
 
 void rai::bootstrap_initiator::bootstrap (rai::endpoint const & endpoint_a)
 {
-    node.peers.insert (endpoint_a, 0x5);
+	node.peers.insert (endpoint_a, 0x5);
 	bootstrap ();
 	std::lock_guard <std::mutex> lock (mutex);
 	if (attempt != nullptr)
 	{
-        attempt->add_connection (endpoint_a);
+		attempt->add_connection (endpoint_a);
 	}
 }
 
@@ -1078,20 +1083,6 @@ void rai::bootstrap_initiator::add_observer (std::function <void (bool)> const &
 	observers.push_back (observer_a);
 }
 
-void rai::bootstrap_initiator::request_account (rai::account const & account_a, rai::block_hash const & hash_a)
-{
-	std::shared_ptr <rai::bootstrap_attempt> attempt_l;
-	{
-		std::lock_guard <std::mutex> lock (mutex);
-		attempt_l = attempt;
-	}
-	if (attempt_l != nullptr)
-	{
-		std::lock_guard <std::mutex> lock (mutex);
-		attempt_l->pulls.push_back (rai::pull_info (account_a, hash_a, hash_a));
-	}
-}
-
 bool rai::bootstrap_initiator::in_progress ()
 {
 	std::lock_guard <std::mutex> lock (mutex);
diff --git a/rai/node/bootstrap.hpp b/rai/node/bootstrap.hpp
index dd3e5d87..30c18fec 100644
--- a/rai/node/bootstrap.hpp
+++ b/rai/node/bootstrap.hpp
@@ -163,7 +163,6 @@ public:
     void bootstrap ();
 	void notify_listeners (bool);
 	void add_observer (std::function <void (bool)> const &);
-	void request_account (rai::account const &, rai::block_hash const &);
 	bool in_progress ();
 	void stop ();
 	rai::node & node;
diff --git a/rai/node/node.cpp b/rai/node/node.cpp
index 6e2b2746..be665c19 100755
--- a/rai/node/node.cpp
+++ b/rai/node/node.cpp
@@ -1170,7 +1170,6 @@ void rai::block_processor::process_receive_many (std::deque <rai::block_processo
 					{
 						// Replace our block with the winner and roll back any dependent blocks
 						BOOST_LOG (node.log) << boost::str (boost::format ("Rolling back %1% and replacing with %2%") % successor->hash ().to_string () % hash.to_string ());
-						node.bootstrap_initiator.request_account (node.ledger.account (transaction, successor->hash ()), hash);
 						node.ledger.rollback (transaction, successor->hash ());
 					}
 				}