Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Recognize IPv4-mapped loopback addresses (#2912)

Browse source 
Address `::ffff:127.0.0.1` isn't currently detected as loopback, which issues the config warning about binding to a non-local address.

Tested `::1, ::ffff:127.0.0.1, ::ffff:0.0.0.0`, only the third one produced the warning.

Thanks to Jav on discord for the notice.
This commit is contained in:
Guilherme Lawless 2020-09-09 17:12:48 +01:00 • committed by GitHub
commit 93845ad2e3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
nano/rpc/rpc.cpp
View file

@ -32,7 +32,8 @@ nano::rpc::~rpc ()
void nano::rpc::start ()
{
auto endpoint (boost::asio::ip::tcp::endpoint (boost::asio::ip::make_address_v6 (config.address), config.port));
if (!endpoint.address ().is_loopback () && config.enable_control)
bool const is_loopback = (endpoint.address ().is_loopback () || (endpoint.address ().to_v6 ().is_v4_mapped () && boost::asio::ip::make_address_v4 (boost::asio::ip::v4_mapped, endpoint.address ().to_v6 ()).is_loopback ()));
if (!is_loopback && config.enable_control)
{
auto warning = boost::str (boost::format ("WARNING: control-level RPCs are enabled on non-local address %1%, potentially allowing wallet access outside local computer") % endpoint.address ().to_string ());
std::cout << warning << std::endl;