From 9c72bebfb1c9b052abe5f6798c9d813862997914 Mon Sep 17 00:00:00 2001
From: gr0vity-dev <85646666+gr0vity-dev@users.noreply.github.com>
Date: Fri, 22 Mar 2024 10:28:00 +0100
Subject: [PATCH] Introduce nano-nightly dockerhub registry for live network
 builds (#4513)

* simplify DOCKER_PASSWORD conditional check

* move env variable declaration to job level

* feat: introduce nano-nightly dockerhub registry for live network

- all non release builds for the live network are pushed to nano-nightly
- only release builds will be pushed to nanocurrency/nano dockerhub registry

* avoid setting `docker_image_name` twice

---------

Co-authored-by: gr0vity-dev <homebot@users.noreply.github.com>
---
 .github/workflows/build_deploy.yml            | 16 +++++++---------
 ci/actions/linux/docker-impl/docker-common.sh |  6 +++++-
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/build_deploy.yml b/.github/workflows/build_deploy.yml
index b9a25f86..49c9a884 100644
--- a/.github/workflows/build_deploy.yml
+++ b/.github/workflows/build_deploy.yml
@@ -155,6 +155,12 @@ jobs:
     strategy:
       matrix:
         network: ["TEST", "BETA", "LIVE"]
+    env:
+      CI_TAG: ${{ needs.prepare_build.outputs.ci_tag }}
+      DOCKER_REGISTRY: ${{ vars.DOCKER_REGISTRY }}
+      DOCKER_USER: ${{ vars.DOCKER_USER }}
+      DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+      IS_RELEASE_BUILD: ${{ github.event.inputs.is_release_build || 'false' }}
     steps:
       - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 #v3.1.0
         with:
@@ -165,23 +171,15 @@ jobs:
         run: ci/actions/linux/docker-build.sh
         env:
           NETWORK: ${{ matrix.network }}
-          CI_TAG: ${{ needs.prepare_build.outputs.ci_tag }}
-          DOCKER_REGISTRY: ${{ vars.DOCKER_REGISTRY }}
-      - name: Check if secrets.DOCKER_PASSWORD exists
-        run: echo "DOCKER_PASSWORD_EXISTS=${{ secrets.DOCKER_PASSWORD != '' }}" >> $GITHUB_ENV
       - name: Deploy Docker Hub
-        if: env.DOCKER_PASSWORD_EXISTS == 'true'
+        if: env.DOCKER_PASSWORD != ''
         run: ci/actions/linux/docker-deploy.sh
         env:
-          CI_TAG: ${{ needs.prepare_build.outputs.ci_tag }}
           NETWORK: ${{ matrix.network }}
-          DOCKER_REGISTRY: ${{ vars.DOCKER_REGISTRY }}
-          DOCKER_USER: ${{ vars.DOCKER_USER }}
           DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
       - name: Deploy Docker (ghcr.io)
         run: ci/actions/linux/ghcr-deploy.sh
         env:
-          CI_TAG: ${{ needs.prepare_build.outputs.ci_tag }}
           NETWORK: ${{ matrix.network }}
           DOCKER_REGISTRY: ghcr.io
           DOCKER_USER: ${{ github.repository_owner }}
diff --git a/ci/actions/linux/docker-impl/docker-common.sh b/ci/actions/linux/docker-impl/docker-common.sh
index bcda39fb..912558b1 100755
--- a/ci/actions/linux/docker-impl/docker-common.sh
+++ b/ci/actions/linux/docker-impl/docker-common.sh
@@ -18,7 +18,11 @@ fi
 
 if [[ "$NETWORK" = "LIVE" ]]; then
     echo "Live"
-    network_tag_suffix=''
+    if [[ "$IS_RELEASE_BUILD" = "true" ]]; then
+        network_tag_suffix=''
+    else
+        network_tag_suffix='-nightly'
+    fi
     network="live"
 elif [[ "$NETWORK" = "BETA" ]]; then
     echo "Beta"