Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix unit test socket.max_connections (#3345)

Browse source 
There were race conditions in the way counters were checked and callbacks
were handled.
This commit is contained in:
dsiganos 2021-06-17 14:03:06 +01:00 • committed by GitHub
commit b14cdd5aa6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
nano/core_test/socket.cpp
View file

@ -63,8 +63,8 @@ TEST (socket, max_connections)
};
ASSERT_TIMELY (5s, get_tcp_accept_failures () == 1);
ASSERT_EQ (get_tcp_accept_successes (), 2);
ASSERT_EQ (connection_attempts, 3);
ASSERT_TIMELY (5s, get_tcp_accept_successes () == 2);
ASSERT_TIMELY (5s, connection_attempts == 3);
// create space for one socket and fill the connections table again
@ -77,8 +77,8 @@ TEST (socket, max_connections)
client5->async_connect (dst_endpoint, connect_handler);
ASSERT_TIMELY (5s, get_tcp_accept_failures () == 2);
ASSERT_EQ (get_tcp_accept_successes (), 3);
ASSERT_EQ (connection_attempts, 5);
ASSERT_TIMELY (5s, get_tcp_accept_successes () == 3);
ASSERT_TIMELY (5s, connection_attempts == 5);
// close all existing sockets and fill the connections table again
// start counting form 1 because 0 is the already closed socket
@ -97,9 +97,9 @@ TEST (socket, max_connections)
client8->async_connect (dst_endpoint, connect_handler);
ASSERT_TIMELY (5s, get_tcp_accept_failures () == 3);
ASSERT_EQ (get_tcp_accept_successes (), 5);
ASSERT_EQ (connection_attempts, 8); // connections initiated by the client
ASSERT_EQ (server_sockets.size (), 5); // connections accepted by the server
ASSERT_TIMELY (5s, get_tcp_accept_successes () == 5);
ASSERT_TIMELY (5s, connection_attempts == 8); // connections initiated by the client
ASSERT_TIMELY (5s, server_sockets.size () == 5); // connections accepted by the server
node->stop ();
runner.stop_event_processing ();