Minecon724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2

Clearing roots after thread has joined to avoid a use-after-free situation.

Browse source 
Boost multi_index iterators remain valid on insertion but not after erasure.
This commit is contained in:
clemahieu 2018-11-08 14:13:27 -06:00
commit c8245e83d9
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rai/node/node.cpp
View file

@ -3007,13 +3007,13 @@ void rai::active_transactions::stop ()
condition.wait (lock);
}
stopped = true;
roots.clear ();
condition.notify_all ();
}
if (thread.joinable ())
{
thread.join ();
}
roots.clear ();
}
bool rai::active_transactions::start (std::shared_ptr<rai::block> block_a, std::function<void(std::shared_ptr<rai::block>)> const & confirmation_action_a)