From d8f8a19737a7e8b24723ddc350eba3f26efebf30 Mon Sep 17 00:00:00 2001 From: Wesley Shillingford Date: Mon, 18 May 2020 12:09:26 +0100 Subject: [PATCH] Deprecate --batch_size/debug_mass_acitvity CLI options (#2769) * Deprecate batch_size CLI option * Also deprecate --generate_mass_activity CLI command --- nano/nano_node/entry.cpp | 2 +- nano/node/cli.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/nano/nano_node/entry.cpp b/nano/nano_node/entry.cpp index 68181459..09da6f30 100644 --- a/nano/nano_node/entry.cpp +++ b/nano/nano_node/entry.cpp @@ -78,7 +78,7 @@ int main (int argc, char * const * argv) ("debug_dump_online_weight", "Dump online_weights table") ("debug_dump_representatives", "List representatives and weights") ("debug_account_count", "Display the number of accounts") - ("debug_mass_activity", "Generates fake debug activity") + ("debug_mass_activity", "(Deprecated) Generates fake debug activity. Can use slow_test's generate_mass_activity test for the same behavior.") ("debug_profile_generate", "Profile work generation") ("debug_profile_validate", "Profile work validation") ("debug_opencl", "OpenCL work generation") diff --git a/nano/node/cli.cpp b/nano/node/cli.cpp index 12cf05b6..bccb131b 100644 --- a/nano/node/cli.cpp +++ b/nano/node/cli.cpp @@ -98,7 +98,7 @@ void nano::add_node_flag_options (boost::program_options::options_description & ("disable_block_processor_unchecked_deletion", "Disable deletion of unchecked blocks after processing") ("allow_bootstrap_peers_duplicates", "Allow multiple connections to same peer in bootstrap attempts") ("fast_bootstrap", "Increase bootstrap speed for high end nodes with higher limits") - ("batch_size", boost::program_options::value(), "Increase sideband batch size, default 512") + ("batch_size", boost::program_options::value(), "(Deprecated) Increase sideband batch size, default 512. This change only affects nodes upgrading from v17 (or earlier) of the node.") ("block_processor_batch_size", boost::program_options::value(), "Increase block processor transaction batch write size, default 0 (limited by config block_processor_batch_max_time), 256k for fast_bootstrap") ("block_processor_full_size", boost::program_options::value(), "Increase block processor allowed blocks queue size before dropping live network packets and holding bootstrap download, default 65536, 1 million for fast_bootstrap") ("block_processor_verification_size", boost::program_options::value(), "Increase batch signature verification size in block processor, default 0 (limited by config signature_checker_threads), unlimited for fast_bootstrap")