From df43cb28e3db873f8191d805d50ff2545d3acbb5 Mon Sep 17 00:00:00 2001 From: clemahieu Date: Tue, 9 Apr 2024 20:42:39 +0100 Subject: [PATCH] Fix intermittent failure of request_aggregator.split by directly confirming setup blocks instead of using an election. (#4546) --- nano/core_test/request_aggregator.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/nano/core_test/request_aggregator.cpp b/nano/core_test/request_aggregator.cpp index 0730a49d..56509018 100644 --- a/nano/core_test/request_aggregator.cpp +++ b/nano/core_test/request_aggregator.cpp @@ -289,10 +289,7 @@ TEST (request_aggregator, split) request.emplace_back (block->hash (), block->root ()); } // Confirm all blocks - node.start_election (blocks.back ()); - std::shared_ptr election; - ASSERT_TIMELY (5s, election = node.active.election (blocks.back ()->qualified_root ())); - election->force_confirm (); + node.ledger.confirm (node.store.tx_begin_write (), blocks.back ()->hash ()); ASSERT_TIMELY_EQ (5s, max_vbh + 2, node.ledger.cemented_count ()); ASSERT_EQ (max_vbh + 1, request.size ()); auto client = std::make_shared (node);