Removing reference from threading.hpp to thread_roles.hpp

nano/lib/plat/darwin/thread_role.cpp

@@ -1,4 +1,4 @@
-#include <nano/lib/threading.hpp>
+#include <nano/lib/thread_roles.hpp>
 
 #include <pthread.h>
 

nano/lib/plat/linux/thread_role.cpp

@@ -1,4 +1,4 @@
-#include <nano/lib/threading.hpp>
+#include <nano/lib/thread_roles.hpp>
 
 #include <pthread.h>
 

nano/lib/plat/windows/thread_role.cpp

@@ -1,4 +1,4 @@
-#include <nano/lib/threading.hpp>
+#include <nano/lib/thread_roles.hpp>
 
 #include <processthreadsapi.h>
 

nano/lib/processing_queue.hpp

@@ -3,6 +3,7 @@
 #include <nano/lib/locks.hpp>
 #include <nano/lib/numbers.hpp>
 #include <nano/lib/stats.hpp>
+#include <nano/lib/thread_roles.hpp>
 #include <nano/lib/threading.hpp>
 #include <nano/lib/utility.hpp>
 
@@ -189,4 +190,4 @@ private:
 	nano::condition_variable condition;
 	std::vector<std::thread> threads;
 };
-}
+}

nano/lib/threading.cpp

@@ -1,13 +1,7 @@
 #include <nano/lib/config.hpp>
+#include <nano/lib/thread_roles.hpp>
 #include <nano/lib/threading.hpp>
 
-#include <boost/asio/post.hpp>
-#include <boost/asio/steady_timer.hpp>
-#include <boost/asio/thread_pool.hpp>
-#include <boost/format.hpp>
-
-#include <future>
-#include <iostream>
 #include <thread>
 
 /*

nano/lib/threading.hpp

@@ -1,25 +1,16 @@
 #pragma once
 
 #include <nano/lib/relaxed_atomic.hpp>
-#include <nano/lib/thread_roles.hpp>
 #include <nano/lib/utility.hpp>
 
 #include <boost/thread/thread.hpp>
 
-#include <latch>
-#include <thread>
-
-namespace boost::asio
-{
-class thread_pool;
-}
-
 namespace nano
 {
 namespace thread_attributes
 {
 	boost::thread::attributes get_default ();
-}
+} // namespace thread_attributes
 
 /**
  * Number of available logical processor cores. Might be overridden by setting `NANO_HARDWARE_CONCURRENCY` environment variable
@@ -28,6 +19,7 @@ unsigned int hardware_concurrency ();
 
 /**
  * If thread is joinable joins it, otherwise does nothing
+ * Returns thread.joinable()
  */
 bool join_or_pass (std::thread &);
-}
+} // namespace nano

nano/lib/work.cpp

@@ -1,6 +1,7 @@
 #include <nano/crypto_lib/random_pool.hpp>
 #include <nano/lib/blocks.hpp>
 #include <nano/lib/epoch.hpp>
+#include <nano/lib/thread_roles.hpp>
 #include <nano/lib/threading.hpp>
 #include <nano/lib/work.hpp>
 #include <nano/node/xorshift.hpp>

nano/node/confirmation_height_processor.cpp

@@ -1,6 +1,6 @@
 #include <nano/lib/logger_mt.hpp>
 #include <nano/lib/numbers.hpp>
-#include <nano/lib/threading.hpp>
+#include <nano/lib/thread_roles.hpp>
 #include <nano/lib/utility.hpp>
 #include <nano/node/confirmation_height_processor.hpp>
 #include <nano/node/write_database_queue.hpp>

nano/node/lmdb/lmdb_txn.cpp

@@ -1,6 +1,6 @@
 #include <nano/lib/jsonconfig.hpp>
 #include <nano/lib/logger_mt.hpp>
-#include <nano/lib/threading.hpp>
+#include <nano/lib/thread_roles.hpp>
 #include <nano/lib/utility.hpp>
 #include <nano/node/lmdb/lmdb_env.hpp>
 #include <nano/node/lmdb/lmdb_txn.hpp>

nano/node/unchecked_map.cpp

@@ -1,7 +1,7 @@
 #include <nano/lib/locks.hpp>
 #include <nano/lib/stats.hpp>
 #include <nano/lib/stats_enums.hpp>
-#include <nano/lib/threading.hpp>
+#include <nano/lib/thread_roles.hpp>
 #include <nano/lib/timer.hpp>
 #include <nano/node/unchecked_map.hpp>
 

nano/rpc/rpc_request_processor.cpp

@@ -1,6 +1,6 @@
 #include <nano/lib/asio.hpp>
 #include <nano/lib/json_error_response.hpp>
-#include <nano/lib/threading.hpp>
+#include <nano/lib/thread_roles.hpp>
 #include <nano/rpc/rpc_request_processor.hpp>
 
 #include <boost/endian/conversion.hpp>

nano/secure/parallel_traversal.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <nano/lib/thread_roles.hpp>
 #include <nano/lib/threading.hpp>
 
 #include <thread>

nano/secure/store.cpp

@@ -1,4 +1,4 @@
-#include <nano/lib/threading.hpp>
+#include <nano/lib/thread_roles.hpp>
 #include <nano/lib/timer.hpp>
 #include <nano/secure/store.hpp>