m724/wtapi
1
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages 1 Wiki Activity Actions

Actually, this name is better

Browse source
This commit is contained in:
Minecon724 2024-09-24 18:39:58 +02:00
commit 31d6873249
No known key found for this signature in database
GPG key ID: 3CCC4D267742C8E8
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/main/java/eu/m724/wtapi/provider/twilight/SimpleTwilightTimeProvider.java → src/main/java/eu/m724/wtapi/provider/twilight/ApproximateTwilightTimeProvider.java
View file

@ -13,7 +13,7 @@ import static java.lang.Math.*;
* Usually off by a few minutes, except the Poles which, during polar days, are up to few hours inaccurate
* Adapted from: <a href="https://gml.noaa.gov/grad/solcalc/solareqns.PDF">https://gml.noaa.gov/grad/solcalc/solareqns.PDF</a>
*/
public class SimpleTwilightTimeProvider extends TwilightTimeProvider {
public class ApproximateTwilightTimeProvider extends TwilightTimeProvider {
@Override
public Twilight calculateTwilightTime(LocalDate date, Coordinates coordinates) {
int dayOfYear = date.getDayOfYear() - 1; // -1 because we have to start from zero

6
src/test/java/eu/m724/wtapi/twilight/SimpleTwilightTimeTest.java → src/test/java/eu/m724/wtapi/twilight/ApproximateTwilightTimeTest.java
View file

@ -2,13 +2,13 @@ package eu.m724.wtapi.twilight;
import eu.m724.wtapi.object.Coordinates;
import eu.m724.wtapi.object.Twilight;
import eu.m724.wtapi.provider.twilight.SimpleTwilightTimeProvider;
import eu.m724.wtapi.provider.twilight.ApproximateTwilightTimeProvider;
import eu.m724.wtapi.provider.twilight.TwilightTimeProvider;
import org.junit.Test;
import java.time.LocalDate;
public class SimpleTwilightTimeTest {
public class ApproximateTwilightTimeTest {
/**
* Acceptable discrepancy in minutes
*/
@ -16,7 +16,7 @@ public class SimpleTwilightTimeTest {
@Test
public void approximateTest() {
TwilightTimeProvider provider = new SimpleTwilightTimeProvider();
TwilightTimeProvider provider = new ApproximateTwilightTimeProvider();
testLocation(provider, 26, 6, 2023, 53.123394, 23.0864867, 122, 1139);
testLocation(provider, 13, 11, 2040, 45.432427, -122.3899276, 907, 1481);