From 1e36e5bcc7c3555bd7ce58b473029ef8563a27ee Mon Sep 17 00:00:00 2001 From: Wesley Shillingford Date: Fri, 1 Mar 2019 15:07:09 +0000 Subject: [PATCH] Don't output useless log file entries (#1785) * Don't output invalid_header or frontier_req failures to log file * Remove a few useless log entries * Formatting --- nano/node/bootstrap.cpp | 2 +- nano/node/node.cpp | 13 ------------- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/nano/node/bootstrap.cpp b/nano/node/bootstrap.cpp index 2fcfa58c5..e50f2f989 100644 --- a/nano/node/bootstrap.cpp +++ b/nano/node/bootstrap.cpp @@ -973,7 +973,7 @@ bool nano::bootstrap_attempt::request_frontier (std::unique_lock & l } else { - node->logger.try_log ("frontier_req failed, reattempting"); + node->stats.inc (nano::stat::type::error, nano::stat::detail::frontier_req, nano::stat::dir::out); } } } diff --git a/nano/node/node.cpp b/nano/node/node.cpp index f220c3dd3..761836b44 100644 --- a/nano/node/node.cpp +++ b/nano/node/node.cpp @@ -867,11 +867,6 @@ void nano::network::receive_action (nano::udp_data * data_a, nano::endpoint cons /* Already checked, unreachable */ break; } - - if (node.config.logging.network_logging () && parser.status != nano::message_parser::parse_status::outdated_version) - { - node.logger.try_log ("Could not parse message. Error: ", parser.status_string ()); - } } else { @@ -1140,10 +1135,6 @@ void nano::vote_processor::vote (std::shared_ptr vote_a, nano::endpo else { node.stats.inc (nano::stat::type::vote, nano::stat::detail::vote_overflow); - if (node.config.logging.vote_logging ()) - { - node.logger.try_log ("Votes overflow"); - } } } } @@ -2989,10 +2980,6 @@ void nano::network::send_buffer (uint8_t const * data_a, size_t size_a, nano::en { this->node.stats.inc (nano::stat::type::error, nano::stat::detail::unreachable_host, nano::stat::dir::out); } - if (this->node.config.logging.network_packet_logging ()) - { - this->node.logger.try_log ("Packet send complete"); - } }); } }