From 238561d955f9267fcbf5462862643f26daaa908c Mon Sep 17 00:00:00 2001 From: Wesley Shillingford Date: Tue, 11 Aug 2020 17:14:50 +0100 Subject: [PATCH] Remove UDP status dead code (#2872) --- nano/lib/stats.cpp | 6 ------ nano/lib/stats.hpp | 2 -- nano/node/common.cpp | 8 -------- nano/node/common.hpp | 2 -- nano/node/transport/udp.cpp | 6 ------ 5 files changed, 24 deletions(-) diff --git a/nano/lib/stats.cpp b/nano/lib/stats.cpp index cb7770d41..dc015b8c8 100644 --- a/nano/lib/stats.cpp +++ b/nano/lib/stats.cpp @@ -655,12 +655,6 @@ std::string nano::stat::detail_to_string (uint32_t key) case nano::stat::detail::unreachable_host: res = "unreachable_host"; break; - case nano::stat::detail::invalid_magic: - res = "invalid_magic"; - break; - case nano::stat::detail::invalid_network: - res = "invalid_network"; - break; case nano::stat::detail::invalid_header: res = "invalid_header"; break; diff --git a/nano/lib/stats.hpp b/nano/lib/stats.hpp index 54ae0119e..d36b1ecfc 100644 --- a/nano/lib/stats.hpp +++ b/nano/lib/stats.hpp @@ -283,8 +283,6 @@ public: // udp blocking, overflow, - invalid_magic, - invalid_network, invalid_header, invalid_message_type, invalid_keepalive_message, diff --git a/nano/node/common.cpp b/nano/node/common.cpp index dbb660326..376cdccc1 100644 --- a/nano/node/common.cpp +++ b/nano/node/common.cpp @@ -310,14 +310,6 @@ std::string nano::message_parser::status_string () { return "outdated_version"; } - case nano::message_parser::parse_status::invalid_magic: - { - return "invalid_magic"; - } - case nano::message_parser::parse_status::invalid_network: - { - return "invalid_network"; - } case nano::message_parser::parse_status::duplicate_publish_message: { return "duplicate_publish_message"; diff --git a/nano/node/common.hpp b/nano/node/common.hpp index 4672b7783..688ba70e3 100644 --- a/nano/node/common.hpp +++ b/nano/node/common.hpp @@ -253,8 +253,6 @@ public: invalid_telemetry_req_message, invalid_telemetry_ack_message, outdated_version, - invalid_magic, - invalid_network, duplicate_publish_message }; message_parser (nano::network_filter &, nano::block_uniquer &, nano::vote_uniquer &, nano::message_visitor &, nano::work_pool &, bool); diff --git a/nano/node/transport/udp.cpp b/nano/node/transport/udp.cpp index 89d40dbcd..371a9a59d 100644 --- a/nano/node/transport/udp.cpp +++ b/nano/node/transport/udp.cpp @@ -564,12 +564,6 @@ void nano::transport::udp_channels::receive_action (nano::message_buffer * data_ // We've already increment error count, update detail only node.stats.inc_detail_only (nano::stat::type::error, nano::stat::detail::insufficient_work); break; - case nano::message_parser::parse_status::invalid_magic: - node.stats.inc (nano::stat::type::udp, nano::stat::detail::invalid_magic); - break; - case nano::message_parser::parse_status::invalid_network: - node.stats.inc (nano::stat::type::udp, nano::stat::detail::invalid_network); - break; case nano::message_parser::parse_status::invalid_header: node.stats.inc (nano::stat::type::udp, nano::stat::detail::invalid_header); break;