diff --git a/nano/core_test/network.cpp b/nano/core_test/network.cpp index 09c6080ce..a31ee9b6c 100644 --- a/nano/core_test/network.cpp +++ b/nano/core_test/network.cpp @@ -614,7 +614,7 @@ TEST (tcp_listener, tcp_listener_timeout_node_id_handshake) ASSERT_TRUE (cookie); nano::node_id_handshake::query_payload query{ *cookie }; nano::node_id_handshake node_id_handshake{ nano::dev::network_params.network, query }; - auto channel = std::make_shared (*node0, socket); + auto channel = std::make_shared (*node0, socket); socket->async_connect (node0->tcp_listener.endpoint (), [&node_id_handshake, channel] (boost::system::error_code const & ec) { ASSERT_FALSE (ec); channel->send (node_id_handshake, [] (boost::system::error_code const & ec, size_t size_a) { diff --git a/nano/core_test/request_aggregator.cpp b/nano/core_test/request_aggregator.cpp index 7fce48d08..8c13577a7 100644 --- a/nano/core_test/request_aggregator.cpp +++ b/nano/core_test/request_aggregator.cpp @@ -37,7 +37,7 @@ TEST (request_aggregator, one) std::vector> request; request.emplace_back (send1->hash (), send1->root ()); auto client = std::make_shared (node); - std::shared_ptr dummy_channel = std::make_shared (node, client); + std::shared_ptr dummy_channel = std::make_shared (node, client); node.aggregator.request (request, dummy_channel); ASSERT_TIMELY (3s, node.aggregator.empty ()); // Not yet in the ledger @@ -169,7 +169,7 @@ TEST (request_aggregator, two) request.emplace_back (send2->hash (), send2->root ()); request.emplace_back (receive1->hash (), receive1->root ()); auto client = std::make_shared (node); - std::shared_ptr dummy_channel = std::make_shared (node, client); + std::shared_ptr dummy_channel = std::make_shared (node, client); // Process both blocks node.aggregator.request (request, dummy_channel); // One vote should be generated for both blocks @@ -288,7 +288,7 @@ TEST (request_aggregator, split) ASSERT_TIMELY_EQ (5s, max_vbh + 2, node.ledger.cemented_count ()); ASSERT_EQ (max_vbh + 1, request.size ()); auto client = std::make_shared (node); - std::shared_ptr dummy_channel = std::make_shared (node, client); + std::shared_ptr dummy_channel = std::make_shared (node, client); node.aggregator.request (request, dummy_channel); // In the ledger but no vote generated yet ASSERT_TIMELY_EQ (3s, 2, node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_generated_votes)); @@ -327,7 +327,7 @@ TEST (request_aggregator, channel_max_queue) std::vector> request; request.emplace_back (send1->hash (), send1->root ()); auto client = std::make_shared (node); - std::shared_ptr dummy_channel = std::make_shared (node, client); + std::shared_ptr dummy_channel = std::make_shared (node, client); node.aggregator.request (request, dummy_channel); node.aggregator.request (request, dummy_channel); ASSERT_LT (0, node.stats.count (nano::stat::type::aggregator, nano::stat::detail::aggregator_dropped)); @@ -356,7 +356,7 @@ TEST (request_aggregator, DISABLED_unique) std::vector> request; request.emplace_back (send1->hash (), send1->root ()); auto client = std::make_shared (node); - std::shared_ptr dummy_channel = std::make_shared (node, client); + std::shared_ptr dummy_channel = std::make_shared (node, client); node.aggregator.request (request, dummy_channel); node.aggregator.request (request, dummy_channel); node.aggregator.request (request, dummy_channel); @@ -401,7 +401,7 @@ TEST (request_aggregator, cannot_vote) // Incorrect hash, correct root request.emplace_back (1, send2->root ()); auto client = std::make_shared (node); - std::shared_ptr dummy_channel = std::make_shared (node, client); + std::shared_ptr dummy_channel = std::make_shared (node, client); node.aggregator.request (request, dummy_channel); ASSERT_TIMELY (3s, node.aggregator.empty ()); ASSERT_EQ (1, node.stats.count (nano::stat::type::aggregator, nano::stat::detail::aggregator_accepted)); diff --git a/nano/core_test/socket.cpp b/nano/core_test/socket.cpp index c4c910eed..898d8c25a 100644 --- a/nano/core_test/socket.cpp +++ b/nano/core_test/socket.cpp @@ -331,7 +331,7 @@ TEST (socket, drop_policy) }); auto client = std::make_shared (*node); - auto channel = std::make_shared (*node, client); + auto channel = std::make_shared (*node, client); std::atomic completed_writes{ 0 }; diff --git a/nano/node/CMakeLists.txt b/nano/node/CMakeLists.txt index c2fd27627..378945a81 100644 --- a/nano/node/CMakeLists.txt +++ b/nano/node/CMakeLists.txt @@ -157,8 +157,8 @@ add_library( telemetry.cpp transport/channel.hpp transport/channel.cpp - transport/channel_tcp.hpp - transport/channel_tcp.cpp + transport/tcp_channel.hpp + transport/tcp_channel.cpp transport/fake.hpp transport/fake.cpp transport/inproc.hpp diff --git a/nano/node/bootstrap/bootstrap.hpp b/nano/node/bootstrap/bootstrap.hpp index 6d2052fc8..252b4b566 100644 --- a/nano/node/bootstrap/bootstrap.hpp +++ b/nano/node/bootstrap/bootstrap.hpp @@ -25,7 +25,7 @@ class node; class bootstrap_connections; namespace transport { - class channel_tcp; + class tcp_channel; } enum class bootstrap_mode { diff --git a/nano/node/bootstrap/bootstrap_connections.cpp b/nano/node/bootstrap/bootstrap_connections.cpp index be78eabfe..79243836e 100644 --- a/nano/node/bootstrap/bootstrap_connections.cpp +++ b/nano/node/bootstrap/bootstrap_connections.cpp @@ -15,7 +15,7 @@ constexpr double nano::bootstrap_limits::bootstrap_minimum_termination_time_sec; constexpr unsigned nano::bootstrap_limits::bootstrap_max_new_connections; constexpr unsigned nano::bootstrap_limits::requeued_pulls_processed_blocks_factor; -nano::bootstrap_client::bootstrap_client (std::shared_ptr const & node_a, std::shared_ptr const & channel_a, std::shared_ptr const & socket_a) : +nano::bootstrap_client::bootstrap_client (std::shared_ptr const & node_a, std::shared_ptr const & channel_a, std::shared_ptr const & socket_a) : node (node_a), channel (channel_a), socket (socket_a), @@ -159,7 +159,7 @@ void nano::bootstrap_connections::connect_client (nano::tcp_endpoint const & end { this_l->node.logger.debug (nano::log::type::bootstrap, "Connection established to: {}", nano::util::to_str (endpoint_a)); - auto client (std::make_shared (this_l->node.shared (), std::make_shared (*this_l->node.shared (), socket), socket)); + auto client (std::make_shared (this_l->node.shared (), std::make_shared (*this_l->node.shared (), socket), socket)); this_l->pool_connection (client, true, push_front); } else diff --git a/nano/node/bootstrap/bootstrap_connections.hpp b/nano/node/bootstrap/bootstrap_connections.hpp index aefbe9761..a0d153f99 100644 --- a/nano/node/bootstrap/bootstrap_connections.hpp +++ b/nano/node/bootstrap/bootstrap_connections.hpp @@ -11,7 +11,7 @@ namespace nano class node; namespace transport { - class channel_tcp; + class tcp_channel; } class bootstrap_attempt; @@ -25,14 +25,14 @@ class pull_info; class bootstrap_client final : public std::enable_shared_from_this { public: - bootstrap_client (std::shared_ptr const & node_a, std::shared_ptr const & channel_a, std::shared_ptr const & socket_a); + bootstrap_client (std::shared_ptr const & node_a, std::shared_ptr const & channel_a, std::shared_ptr const & socket_a); ~bootstrap_client (); void stop (bool force); double sample_block_rate (); double elapsed_seconds () const; void set_start_time (std::chrono::steady_clock::time_point start_time_a); std::weak_ptr node; - std::shared_ptr channel; + std::shared_ptr channel; std::shared_ptr socket; std::shared_ptr> receive_buffer; std::atomic block_count{ 0 }; diff --git a/nano/node/transport/fwd.hpp b/nano/node/transport/fwd.hpp index be3b9a074..b10e3dd3c 100644 --- a/nano/node/transport/fwd.hpp +++ b/nano/node/transport/fwd.hpp @@ -3,6 +3,6 @@ namespace nano::transport { class channel; -class channel_tcp; +class tcp_channel; class tcp_channels; } \ No newline at end of file diff --git a/nano/node/transport/channel_tcp.cpp b/nano/node/transport/tcp_channel.cpp similarity index 86% rename from nano/node/transport/channel_tcp.cpp rename to nano/node/transport/tcp_channel.cpp index 3da78a5c1..3c4bae842 100644 --- a/nano/node/transport/channel_tcp.cpp +++ b/nano/node/transport/tcp_channel.cpp @@ -1,20 +1,20 @@ #include #include #include -#include #include +#include /* - * channel_tcp + * tcp_channel */ -nano::transport::channel_tcp::channel_tcp (nano::node & node_a, std::weak_ptr socket_a) : +nano::transport::tcp_channel::tcp_channel (nano::node & node_a, std::weak_ptr socket_a) : channel (node_a), socket (std::move (socket_a)) { } -nano::transport::channel_tcp::~channel_tcp () +nano::transport::tcp_channel::~tcp_channel () { nano::lock_guard lk{ channel_mutex }; // Close socket. Exception: socket is used by tcp_server @@ -24,7 +24,7 @@ nano::transport::channel_tcp::~channel_tcp () } } -void nano::transport::channel_tcp::update_endpoints () +void nano::transport::tcp_channel::update_endpoints () { nano::lock_guard lk (channel_mutex); @@ -38,7 +38,7 @@ void nano::transport::channel_tcp::update_endpoints () } } -void nano::transport::channel_tcp::send_buffer (nano::shared_const_buffer const & buffer_a, std::function const & callback_a, nano::transport::buffer_drop_policy policy_a, nano::transport::traffic_type traffic_type) +void nano::transport::tcp_channel::send_buffer (nano::shared_const_buffer const & buffer_a, std::function const & callback_a, nano::transport::buffer_drop_policy policy_a, nano::transport::traffic_type traffic_type) { if (auto socket_l = socket.lock ()) { @@ -88,12 +88,12 @@ void nano::transport::channel_tcp::send_buffer (nano::shared_const_buffer const } } -std::string nano::transport::channel_tcp::to_string () const +std::string nano::transport::tcp_channel::to_string () const { return nano::util::to_str (get_tcp_endpoint ()); } -void nano::transport::channel_tcp::operator() (nano::object_stream & obs) const +void nano::transport::tcp_channel::operator() (nano::object_stream & obs) const { nano::transport::channel::operator() (obs); // Write common data diff --git a/nano/node/transport/channel_tcp.hpp b/nano/node/transport/tcp_channel.hpp similarity index 89% rename from nano/node/transport/channel_tcp.hpp rename to nano/node/transport/tcp_channel.hpp index d268e91fa..9ad9026cf 100644 --- a/nano/node/transport/channel_tcp.hpp +++ b/nano/node/transport/tcp_channel.hpp @@ -7,15 +7,15 @@ namespace nano::transport { class tcp_server; class tcp_channels; -class channel_tcp; +class tcp_channel; -class channel_tcp : public nano::transport::channel, public std::enable_shared_from_this +class tcp_channel : public nano::transport::channel, public std::enable_shared_from_this { friend class nano::transport::tcp_channels; public: - channel_tcp (nano::node &, std::weak_ptr); - ~channel_tcp () override; + tcp_channel (nano::node &, std::weak_ptr); + ~tcp_channel () override; void update_endpoints (); diff --git a/nano/node/transport/tcp_channels.cpp b/nano/node/transport/tcp_channels.cpp index 54f083b21..15d94e610 100644 --- a/nano/node/transport/tcp_channels.cpp +++ b/nano/node/transport/tcp_channels.cpp @@ -91,7 +91,7 @@ bool nano::transport::tcp_channels::check (const nano::tcp_endpoint & endpoint, } // This should be the only place in node where channels are created -std::shared_ptr nano::transport::tcp_channels::create (const std::shared_ptr & socket, const std::shared_ptr & server, const nano::account & node_id) +std::shared_ptr nano::transport::tcp_channels::create (const std::shared_ptr & socket, const std::shared_ptr & server, const nano::account & node_id) { auto const endpoint = socket->remote_endpoint (); debug_assert (endpoint.address ().is_v6 ()); @@ -117,7 +117,7 @@ std::shared_ptr nano::transport::tcp_channels::cre fmt::streamed (socket->remote_endpoint ()), node_id.to_node_id ()); - auto channel = std::make_shared (node, socket); + auto channel = std::make_shared (node, socket); channel->update_endpoints (); channel->set_node_id (node_id); @@ -145,10 +145,10 @@ std::size_t nano::transport::tcp_channels::size () const return channels.size (); } -std::shared_ptr nano::transport::tcp_channels::find_channel (nano::tcp_endpoint const & endpoint_a) const +std::shared_ptr nano::transport::tcp_channels::find_channel (nano::tcp_endpoint const & endpoint_a) const { nano::lock_guard lock{ mutex }; - std::shared_ptr result; + std::shared_ptr result; auto existing (channels.get ().find (endpoint_a)); if (existing != channels.get ().end ()) { @@ -202,9 +202,9 @@ void nano::transport::tcp_channels::random_fill (std::array & } } -std::shared_ptr nano::transport::tcp_channels::find_node_id (nano::account const & node_id_a) +std::shared_ptr nano::transport::tcp_channels::find_node_id (nano::account const & node_id_a) { - std::shared_ptr result; + std::shared_ptr result; nano::lock_guard lock{ mutex }; auto existing (channels.get ().find (node_id_a)); if (existing != channels.get ().end ()) @@ -387,7 +387,7 @@ void nano::transport::tcp_channels::keepalive () auto const cutoff_time = std::chrono::steady_clock::now () - node.network_params.network.keepalive_period; // Wake up channels - std::vector> to_wakeup; + std::vector> to_wakeup; for (auto const & entry : channels) { if (entry.channel->get_last_packet_sent () < cutoff_time) @@ -434,7 +434,7 @@ void nano::transport::tcp_channels::list (std::deque const & channel_a, std::function const &)> modify_callback_a) +void nano::transport::tcp_channels::modify (std::shared_ptr const & channel_a, std::function const &)> modify_callback_a) { nano::lock_guard lock{ mutex }; auto existing (channels.get ().find (channel_a->get_tcp_endpoint ())); diff --git a/nano/node/transport/tcp_channels.hpp b/nano/node/transport/tcp_channels.hpp index 46d0e9e04..ddd1abab3 100644 --- a/nano/node/transport/tcp_channels.hpp +++ b/nano/node/transport/tcp_channels.hpp @@ -3,7 +3,7 @@ #include #include #include -#include +#include #include #include @@ -23,7 +23,7 @@ namespace nano::transport { class tcp_channels final { - friend class channel_tcp; + friend class tcp_channel; friend class telemetry_simultaneous_requests_Test; friend class network_peer_max_tcp_attempts_subnetwork_Test; @@ -34,13 +34,13 @@ public: void start (); void stop (); - std::shared_ptr create (std::shared_ptr const &, std::shared_ptr const &, nano::account const & node_id); + std::shared_ptr create (std::shared_ptr const &, std::shared_ptr const &, nano::account const & node_id); void erase (nano::tcp_endpoint const &); std::size_t size () const; - std::shared_ptr find_channel (nano::tcp_endpoint const &) const; + std::shared_ptr find_channel (nano::tcp_endpoint const &) const; void random_fill (std::array &) const; std::unordered_set> random_set (std::size_t, uint8_t = 0, bool = false) const; - std::shared_ptr find_node_id (nano::account const &); + std::shared_ptr find_node_id (nano::account const &); // Get the next peer for attempting a tcp connection nano::tcp_endpoint bootstrap_peer (); bool max_ip_connections (nano::tcp_endpoint const & endpoint_a); @@ -51,7 +51,7 @@ public: std::unique_ptr collect_container_info (std::string const &); void purge (std::chrono::steady_clock::time_point cutoff_deadline); void list (std::deque> &, uint8_t = 0, bool = true); - void modify (std::shared_ptr const &, std::function const &)>); + void modify (std::shared_ptr const &, std::function const &)>); void keepalive (); std::optional sample_keepalive (); @@ -69,12 +69,12 @@ private: class channel_entry final { public: - std::shared_ptr channel; + std::shared_ptr channel; std::shared_ptr socket; std::shared_ptr response_server; public: - channel_entry (std::shared_ptr channel_a, std::shared_ptr socket_a, std::shared_ptr server_a) : + channel_entry (std::shared_ptr channel_a, std::shared_ptr socket_a, std::shared_ptr server_a) : channel (std::move (channel_a)), socket (std::move (socket_a)), response_server (std::move (server_a)) { } diff --git a/nano/node/transport/tcp_server.hpp b/nano/node/transport/tcp_server.hpp index 20ba3a93d..6301014e9 100644 --- a/nano/node/transport/tcp_server.hpp +++ b/nano/node/transport/tcp_server.hpp @@ -76,7 +76,7 @@ private: std::optional last_keepalive; // Every realtime connection must have an associated channel - std::shared_ptr channel; + std::shared_ptr channel; private: // Visitors class handshake_message_visitor : public nano::message_visitor diff --git a/nano/test_common/network.cpp b/nano/test_common/network.cpp index bb37ff12d..ed31a3b40 100644 --- a/nano/test_common/network.cpp +++ b/nano/test_common/network.cpp @@ -10,11 +10,11 @@ using namespace std::chrono_literals; -std::shared_ptr nano::test::establish_tcp (nano::test::system & system, nano::node & node, nano::endpoint const & endpoint) +std::shared_ptr nano::test::establish_tcp (nano::test::system & system, nano::node & node, nano::endpoint const & endpoint) { debug_assert (node.network.endpoint () != endpoint && "Establishing TCP to self is not allowed"); - std::shared_ptr result; + std::shared_ptr result; debug_assert (!node.flags.disable_tcp_realtime); node.network.tcp_channels.start_tcp (endpoint); auto error = system.poll_until_true (2s, [&result, &node, &endpoint] { diff --git a/nano/test_common/network.hpp b/nano/test_common/network.hpp index db90344f5..3bfcd22c3 100644 --- a/nano/test_common/network.hpp +++ b/nano/test_common/network.hpp @@ -10,14 +10,14 @@ class node; namespace transport { class channel; - class channel_tcp; + class tcp_channel; } namespace test { class system; /** Waits until a TCP connection is established and returns the TCP channel on success*/ - std::shared_ptr establish_tcp (nano::test::system &, nano::node &, nano::endpoint const &); + std::shared_ptr establish_tcp (nano::test::system &, nano::node &, nano::endpoint const &); /** Adds a node to the system without establishing connections */ std::shared_ptr add_outer_node (nano::test::system & system, nano::node_config const & config_a, nano::node_flags = nano::node_flags ());