dn724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix intermittent failure in test wallet.work_cache_delayed (#2760)

Browse source 
By random chance, the pre-set work could pass even for the blocks it's not intended for (due to test difficulty being low). The two removed lines are, in the end, out of scope for this test.
This commit is contained in:
Guilherme Lawless 2020-05-06 21:14:42 +01:00 • committed by GitHub
commit 2e37a5e969
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
nano/core_test/wallet.cpp
View file

@ -713,8 +713,6 @@ TEST (wallet, work_cache_delayed)
ASSERT_NO_ERROR (system.poll ()); ASSERT_NO_ERROR (system.poll ());
if (!wallet->store.work_get (node1.wallets.tx_begin_read (), account1, work1)) if (!wallet->store.work_get (node1.wallets.tx_begin_read (), account1, work1))
{ {
ASSERT_LT (nano::work_difficulty (nano::work_version::work_1, nano::test_genesis_key.pub, work1), threshold);
ASSERT_LT (nano::work_difficulty (nano::work_version::work_1, block1->hash (), work1), threshold);
again = nano::work_difficulty (nano::work_version::work_1, block2->hash (), work1) < threshold; again = nano::work_difficulty (nano::work_version::work_1, block2->hash (), work1) < threshold;
} }
} }