observer_set: do not call the observer callbacks holding the lock (#3922)

It unnecessarily leaves the door open for deadlocks.

nano/lib/utility.hpp

@@ -158,8 +158,11 @@ public:
 	}
 	void notify (T... args)
 	{
-		nano::lock_guard<nano::mutex> lock (mutex);
+		nano::unique_lock<nano::mutex> lock (mutex);
-		for (auto & i : observers)
+		auto observers_copy = observers;
+		lock.unlock ();
+
+		for (auto & i : observers_copy)
 		{
 			i (args...);
 		}