dn724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Optimize mutex access when adding blocks to block processor (#2676)

Browse source
This commit is contained in:
Guilherme Lawless 2020-03-23 10:12:40 +00:00 • committed by GitHub
commit 89a8e6d153
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
nano/node/blockprocessor.cpp
View file

@ -76,24 +76,21 @@ void nano::block_processor::add (std::shared_ptr<nano::block> block_a, uint64_t
void nano::block_processor::add (nano::unchecked_info const & info_a) void nano::block_processor::add (nano::unchecked_info const & info_a)
{ {
debug_assert (!nano::work_validate (*info_a.block)); debug_assert (!nano::work_validate (*info_a.block));
bool should_notify{ false };
if (info_a.block->difficulty () >= nano::work_threshold (info_a.block->work_version ())) if (info_a.block->difficulty () >= nano::work_threshold (info_a.block->work_version ()))
{ {
nano::lock_guard<std::mutex> lock (mutex);
if (info_a.verified == nano::signature_verification::unknown && (info_a.block->type () == nano::block_type::state || info_a.block->type () == nano::block_type::open || !info_a.account.is_zero ())) if (info_a.verified == nano::signature_verification::unknown && (info_a.block->type () == nano::block_type::state || info_a.block->type () == nano::block_type::open || !info_a.account.is_zero ()))
{ {
state_block_signature_verification.add (info_a); state_block_signature_verification.add (info_a);
} }
else else
{ {
should_notify = true; {
blocks.push_back (info_a); nano::lock_guard<std::mutex> guard (mutex);
blocks.push_back (info_a);
}
condition.notify_all ();
} }
} }
if (should_notify)
{
condition.notify_all ();
}
} }
void nano::block_processor::force (std::shared_ptr<nano::block> block_a) void nano::block_processor::force (std::shared_ptr<nano::block> block_a)