From 96ccbda1a82ec26479b73575c437c7a9bd4dae04 Mon Sep 17 00:00:00 2001 From: dsiganos Date: Wed, 16 Jun 2021 01:24:50 +0100 Subject: [PATCH] Fix unit test deferred dependent elections (#3338) The test was not calling election scheduler flush when it should. --- nano/core_test/node.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/nano/core_test/node.cpp b/nano/core_test/node.cpp index 8d84bd399..41d6237b4 100644 --- a/nano/core_test/node.cpp +++ b/nano/core_test/node.cpp @@ -4574,6 +4574,7 @@ TEST (node, deferred_dependent_elections) node.process_local (open); node.process_local (send2); node.block_processor.flush (); + node.scheduler.flush (); ASSERT_TRUE (node.block (open->hash ())); ASSERT_TRUE (node.block (send2->hash ())); ASSERT_FALSE (node.active.active (open->qualified_root ())); @@ -4585,6 +4586,7 @@ TEST (node, deferred_dependent_elections) node.work_generate_blocking (*open, open->difficulty () + 1); node.process_local (open); node.block_processor.flush (); + node.scheduler.flush (); ASSERT_FALSE (node.active.active (open->qualified_root ())); // It is however possible to manually start an election from elsewhere @@ -4598,6 +4600,7 @@ TEST (node, deferred_dependent_elections) ASSERT_FALSE (node.active.active (open->qualified_root ())); node.process_local (open); node.block_processor.flush (); + node.scheduler.flush (); ASSERT_FALSE (node.active.active (open->qualified_root ())); // Frontier confirmation also starts elections @@ -4635,6 +4638,7 @@ TEST (node, deferred_dependent_elections) ASSERT_FALSE (node.block (receive->hash ())); node.process_local (receive); node.block_processor.flush (); + node.scheduler.flush (); ASSERT_TRUE (node.block (receive->hash ())); ASSERT_FALSE (node.active.active (receive->qualified_root ())); @@ -4642,6 +4646,7 @@ TEST (node, deferred_dependent_elections) ASSERT_EQ (nano::process_result::fork, node.process (*fork).code); node.process_local (fork); node.block_processor.flush (); + node.scheduler.flush (); ASSERT_FALSE (node.active.active (receive->qualified_root ())); // Confirming the other dependency allows starting an election from a fork