From 9b30b399b3904551d0703d5309d2e5d3a8fed540 Mon Sep 17 00:00:00 2001 From: cryptocode Date: Mon, 11 Nov 2019 15:44:49 +0100 Subject: [PATCH] Warn if control is enabled with non-local bind address (#2401) --- nano/rpc/rpc.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/nano/rpc/rpc.cpp b/nano/rpc/rpc.cpp index e775ec747..42e82278c 100644 --- a/nano/rpc/rpc.cpp +++ b/nano/rpc/rpc.cpp @@ -29,6 +29,12 @@ nano::rpc::~rpc () void nano::rpc::start () { auto endpoint (boost::asio::ip::tcp::endpoint (config.address, config.port)); + if (!endpoint.address ().is_loopback () && config.enable_control) + { + auto warning = boost::str (boost::format ("WARNING: control-level RPCs are enabled on non-local address %1%, potentially allowing wallet access outside local computer") % endpoint.address ().to_string ()); + std::cout << warning << std::endl; + logger.always_log (warning); + } acceptor.open (endpoint.protocol ()); acceptor.set_option (boost::asio::ip::tcp::acceptor::reuse_address (true));