dn724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Rewrite json_handler::receivable in terms of receivable iterators

Browse source
This commit is contained in:
Colin LeMahieu 2024-03-15 23:10:11 +00:00
commit 9d962e6e46
No known key found for this signature in database
GPG key ID: 43708520C8DFB938
1 changed files with 47 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

95
nano/node/json_handler.cpp
View file

@ -3051,66 +3051,65 @@ void nano::json_handler::receivable ()
{ {
auto offset_counter = offset; auto offset_counter = offset;
boost::property_tree::ptree peers_l; boost::property_tree::ptree peers_l;
auto transaction (node.store.tx_begin_read ()); auto transaction = node.store.tx_begin_read ();
// The ptree container is used if there are any children nodes (e.g source/min_version) otherwise the amount container is used. // The ptree container is used if there are any children nodes (e.g source/min_version) otherwise the amount container is used.
std::vector<std::pair<std::string, boost::property_tree::ptree>> hash_ptree_pairs; std::vector<std::pair<std::string, boost::property_tree::ptree>> hash_ptree_pairs;
std::vector<std::pair<std::string, nano::uint128_t>> hash_amount_pairs; std::vector<std::pair<std::string, nano::uint128_t>> hash_amount_pairs;
for (auto i (node.store.pending.begin (transaction, nano::pending_key (account, 0))), n (node.store.pending.end ()); i != n && nano::pending_key (i->first).account == account && (should_sort || peers_l.size () < count); ++i) for (auto current = node.ledger.receivable_upper_bound (transaction, account, 0), end = node.ledger.receivable_end (); current != end && (should_sort || peers_l.size () < count); ++current)
{ {
nano::pending_key const & key (i->first); auto const & [key, info] = *current;
if (block_confirmed (node, transaction, key.hash, include_active, include_only_confirmed)) if (include_only_confirmed && !node.ledger.block_confirmed (transaction, key.hash))
{ {
if (!should_sort && offset_counter > 0) continue;
}
if (!should_sort && offset_counter > 0)
{
--offset_counter;
continue;
}
if (simple)
{
boost::property_tree::ptree entry;
entry.put ("", key.hash.to_string ());
peers_l.push_back (std::make_pair ("", entry));
continue;
}
if (info.amount.number () < threshold.number ())
{
continue;
}
if (source || min_version)
{
boost::property_tree::ptree pending_tree;
pending_tree.put ("amount", info.amount.number ().template convert_to<std::string> ());
if (source)
{ {
--offset_counter; pending_tree.put ("source", info.source.to_account ());
continue; }
if (min_version)
{
pending_tree.put ("min_version", epoch_as_string (info.epoch));
} }
if (simple) if (should_sort)
{ {
boost::property_tree::ptree entry; hash_ptree_pairs.emplace_back (key.hash.to_string (), pending_tree);
entry.put ("", key.hash.to_string ());
peers_l.push_back (std::make_pair ("", entry));
} }
else else
{ {
nano::pending_info const & info (i->second); peers_l.add_child (key.hash.to_string (), pending_tree);
if (info.amount.number () >= threshold.number ()) }
{ }
if (source || min_version) else
{ {
boost::property_tree::ptree pending_tree; if (should_sort)
pending_tree.put ("amount", info.amount.number ().convert_to<std::string> ()); {
if (source) hash_amount_pairs.emplace_back (key.hash.to_string (), info.amount.number ());
{ }
pending_tree.put ("source", info.source.to_account ()); else
} {
if (min_version) peers_l.put (key.hash.to_string (), info.amount.number ().template convert_to<std::string> ());
{
pending_tree.put ("min_version", epoch_as_string (info.epoch));
}
if (should_sort)
{
hash_ptree_pairs.emplace_back (key.hash.to_string (), pending_tree);
}
else
{
peers_l.add_child (key.hash.to_string (), pending_tree);
}
}
else
{
if (should_sort)
{
hash_amount_pairs.emplace_back (key.hash.to_string (), info.amount.number ());
}
else
{
peers_l.put (key.hash.to_string (), info.amount.number ().convert_to<std::string> ());
}
}
}
} }
} }
} }