Remove inclusion of vote in common.hpp header.

nano/core_test/active_elections.cpp

@@ -11,6 +11,7 @@
 #include <nano/secure/ledger.hpp>
 #include <nano/secure/ledger_set_any.hpp>
 #include <nano/secure/ledger_set_confirmed.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/chains.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>

nano/core_test/block.cpp

@@ -1,3 +1,4 @@
+#include <nano/lib/block_uniquer.hpp>
 #include <nano/lib/blocks.hpp>
 #include <nano/lib/stream.hpp>
 #include <nano/lib/work_version.hpp>

nano/core_test/conflicts.cpp

@@ -4,6 +4,7 @@
 #include <nano/node/scheduler/component.hpp>
 #include <nano/node/scheduler/priority.hpp>
 #include <nano/secure/ledger.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/chains.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>

nano/core_test/ledger.cpp

@@ -12,6 +12,7 @@
 #include <nano/node/vote_router.hpp>
 #include <nano/secure/ledger_set_any.hpp>
 #include <nano/secure/ledger_set_confirmed.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/store/rocksdb/rocksdb.hpp>
 #include <nano/test_common/ledger_context.hpp>
 #include <nano/test_common/make_store.hpp>

nano/core_test/memory_pool.cpp

@@ -2,6 +2,7 @@
 #include <nano/lib/memory.hpp>
 #include <nano/node/active_elections.hpp>
 #include <nano/secure/common.hpp>
+#include <nano/secure/vote.hpp>
 
 #include <gtest/gtest.h>
 

nano/core_test/message.cpp

@@ -3,6 +3,7 @@
 #include <nano/lib/stream.hpp>
 #include <nano/node/endpoint.hpp>
 #include <nano/node/network.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/testutil.hpp>
 
 #include <gtest/gtest.h>

nano/core_test/message_deserializer.cpp

@@ -1,5 +1,6 @@
 #include <nano/lib/blocks.hpp>
 #include <nano/node/transport/message_deserializer.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>
 

nano/core_test/node.cpp

@@ -20,6 +20,7 @@
 #include <nano/secure/ledger.hpp>
 #include <nano/secure/ledger_set_any.hpp>
 #include <nano/secure/ledger_set_confirmed.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/network.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>

nano/core_test/rep_crawler.cpp

@@ -6,6 +6,7 @@
 #include <nano/node/transport/fake.hpp>
 #include <nano/node/transport/inproc.hpp>
 #include <nano/secure/ledger.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/chains.hpp>
 #include <nano/test_common/network.hpp>
 #include <nano/test_common/system.hpp>
@@ -327,4 +328,4 @@ TEST (rep_crawler, ignore_rebroadcasted)
 	};
 
 	ASSERT_NEVER (1s, tick () || node1.rep_crawler.representative_count () > 0);
-}
+}

nano/core_test/vote_processor.cpp

@@ -6,6 +6,7 @@
 #include <nano/node/vote_processor.hpp>
 #include <nano/node/vote_router.hpp>
 #include <nano/secure/ledger.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/chains.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>

nano/core_test/voting.cpp

@@ -4,6 +4,7 @@
 #include <nano/node/vote_generator.hpp>
 #include <nano/node/vote_spacing.hpp>
 #include <nano/secure/ledger.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>
 

nano/lib/blocks.cpp

@@ -1,5 +1,6 @@
 #include <nano/crypto_lib/random_pool.hpp>
 #include <nano/lib/block_type.hpp>
+#include <nano/lib/block_uniquer.hpp>
 #include <nano/lib/blocks.hpp>
 #include <nano/lib/enum_util.hpp>
 #include <nano/lib/memory.hpp>

nano/nano_node/entry.cpp

@@ -17,6 +17,7 @@
 #include <nano/node/transport/inproc.hpp>
 #include <nano/secure/ledger.hpp>
 #include <nano/secure/ledger_set_any.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/store/pending.hpp>
 
 #include <boost/dll/runtime_symbol_info.hpp>

nano/node/bandwidth_limiter.hpp

@@ -4,6 +4,11 @@
 #include <nano/node/fwd.hpp>
 #include <nano/node/transport/traffic_type.hpp>
 
+namespace nano
+{
+class node_config;
+}
+
 namespace nano
 {
 class bandwidth_limiter_config final
@@ -50,4 +55,4 @@ private:
 	nano::rate_limiter limiter_generic;
 	nano::rate_limiter limiter_bootstrap;
 };
-}
+}

nano/node/bootstrap/bootstrap.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <nano/lib/numbers.hpp>
 #include <nano/node/bootstrap/bootstrap_connections.hpp>
 #include <nano/node/endpoint.hpp>
 

nano/node/bootstrap/bootstrap_attempt.hpp

@@ -2,6 +2,8 @@
 
 #include <nano/node/bootstrap/bootstrap.hpp>
 
+#include <boost/property_tree/ptree.hpp>
+
 #include <atomic>
 #include <future>
 

nano/node/bootstrap_ascending/account_sets.hpp

@@ -18,8 +18,12 @@ namespace mi = boost::multi_index;
 
 namespace nano
 {
+class account_sets_config;
 class stats;
+}
 
+namespace nano
+{
 namespace bootstrap_ascending
 {
 	/** This class tracks accounts various account sets which are shared among the multiple bootstrap threads */
@@ -161,4 +165,4 @@ namespace bootstrap_ascending
 		info_t info () const;
 	};
 }
-}
+}

nano/node/confirming_set.hpp

@@ -20,6 +20,14 @@
 
 namespace mi = boost::multi_index;
 
+namespace nano
+{
+class election;
+class ledger;
+class logger;
+class stats;
+}
+
 namespace nano
 {
 class confirming_set_config final

nano/node/election.cpp

@@ -9,6 +9,7 @@
 #include <nano/node/vote_generator.hpp>
 #include <nano/node/vote_router.hpp>
 #include <nano/secure/ledger.hpp>
+#include <nano/secure/vote.hpp>
 
 using namespace std::chrono;
 

nano/node/endpoint.cpp

@@ -6,6 +6,7 @@
 #include <nano/node/endpoint.hpp>
 #include <nano/node/network.hpp>
 #include <nano/node/wallet.hpp>
+#include <nano/secure/vote.hpp>
 
 #include <boost/format.hpp>
 

nano/node/ipc/ipc_config.cpp

@@ -2,6 +2,12 @@
 #include <nano/lib/tomlconfig.hpp>
 #include <nano/node/ipc/ipc_config.hpp>
 
+nano::ipc::ipc_config_tcp_socket::ipc_config_tcp_socket (nano::network_constants & network_constants) :
+	network_constants{ network_constants },
+	port{ network_constants.default_ipc_port }
+{
+}
+
 nano::error nano::ipc::ipc_config::serialize_toml (nano::tomlconfig & toml) const
 {
 	nano::tomlconfig tcp_l;

nano/node/ipc/ipc_config.hpp

@@ -7,7 +7,12 @@
 
 namespace nano
 {
+class network_constants;
 class tomlconfig;
+}
+
+namespace nano
+{
 namespace ipc
 {
 	/** Base class for transport configurations */
@@ -46,11 +51,7 @@ namespace ipc
 	class ipc_config_tcp_socket : public ipc_config_transport
 	{
 	public:
-		ipc_config_tcp_socket (nano::network_constants & network_constants) :
-			network_constants{ network_constants },
-			port{ network_constants.default_ipc_port }
-		{
-		}
+		ipc_config_tcp_socket (nano::network_constants & network_constants);
 		nano::network_constants & network_constants;
 		/** Listening port */
 		uint16_t port;

nano/node/local_block_broadcaster.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <nano/lib/blocks.hpp>
+#include <nano/lib/interval.hpp>
 #include <nano/lib/locks.hpp>
 #include <nano/lib/processing_queue.hpp>
 #include <nano/lib/rate_limiting.hpp>

nano/node/message_processor.cpp

@@ -3,6 +3,7 @@
 #include <nano/node/message_processor.hpp>
 #include <nano/node/node.hpp>
 #include <nano/node/telemetry.hpp>
+#include <nano/secure/vote.hpp>
 
 nano::message_processor::message_processor (message_processor_config const & config_a, nano::node & node_a) :
 	config{ config_a },
@@ -317,4 +318,4 @@ nano::error nano::message_processor_config::deserialize (nano::tomlconfig & toml
 	toml.get ("max_queue", max_queue);
 
 	return toml.get_error ();
-}
+}

nano/node/messages.cpp

@@ -12,6 +12,7 @@
 #include <nano/node/endpoint.hpp>
 #include <nano/node/messages.hpp>
 #include <nano/node/network.hpp>
+#include <nano/secure/vote.hpp>
 
 #include <boost/asio/ip/address_v6.hpp>
 #include <boost/endian/conversion.hpp>

nano/node/messages.hpp

@@ -27,8 +27,10 @@ class block;
 class jsonconfig;
 template <typename Key, typename Value>
 class uniquer;
+class vote;
 
 using block_uniquer = uniquer<nano::uint256_union, nano::block>;
+using vote_uniquer = uniquer<nano::block_hash, nano::vote>;
 }
 
 namespace nano

nano/node/node.cpp

@@ -39,6 +39,7 @@
 #include <nano/secure/ledger.hpp>
 #include <nano/secure/ledger_set_any.hpp>
 #include <nano/secure/ledger_set_confirmed.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/store/component.hpp>
 #include <nano/store/rocksdb/rocksdb.hpp>
 

nano/node/repcrawler.cpp

@@ -2,6 +2,7 @@
 #include <nano/node/node.hpp>
 #include <nano/node/repcrawler.hpp>
 #include <nano/secure/ledger.hpp>
+#include <nano/secure/vote.hpp>
 
 #include <ranges>
 

nano/node/scheduler/bucket.hpp

@@ -1,5 +1,7 @@
 #pragma once
 
+#include <nano/lib/errors.hpp>
+#include <nano/lib/numbers.hpp>
 #include <nano/node/fwd.hpp>
 #include <nano/secure/common.hpp>
 

nano/node/vote_cache.cpp

@@ -3,6 +3,7 @@
 #include <nano/node/node.hpp>
 #include <nano/node/vote_cache.hpp>
 #include <nano/node/vote_router.hpp>
+#include <nano/secure/vote.hpp>
 
 #include <ranges>
 

nano/node/vote_generator.cpp

@@ -11,6 +11,7 @@
 #include <nano/node/wallet.hpp>
 #include <nano/secure/ledger.hpp>
 #include <nano/secure/ledger_set_any.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/store/component.hpp>
 
 #include <chrono>
@@ -326,4 +327,4 @@ nano::container_info nano::vote_generator::container_info () const
 	info.put ("requests", requests.size ());
 	info.add ("queue", vote_generation_queue.container_info ());
 	return info;
-}
+}

nano/node/vote_processor.cpp

@@ -10,6 +10,7 @@
 #include <nano/node/vote_router.hpp>
 #include <nano/secure/common.hpp>
 #include <nano/secure/ledger.hpp>
+#include <nano/secure/vote.hpp>
 
 #include <chrono>
 
@@ -376,4 +377,4 @@ nano::error nano::vote_processor_config::deserialize (nano::tomlconfig & toml)
 	toml.get ("batch_size", batch_size);
 
 	return toml.get_error ();
-}
+}

nano/node/vote_router.cpp

@@ -5,6 +5,7 @@
 #include <nano/node/election.hpp>
 #include <nano/node/vote_cache.hpp>
 #include <nano/node/vote_router.hpp>
+#include <nano/secure/vote.hpp>
 
 #include <chrono>
 
@@ -192,4 +193,4 @@ nano::container_info nano::vote_router::container_info () const
 	nano::container_info info;
 	info.put ("elections", elections);
 	return info;
-}
+}

nano/node/websocket.cpp

@@ -13,6 +13,7 @@
 #include <nano/node/wallet.hpp>
 #include <nano/node/websocket.hpp>
 #include <nano/secure/ledger.hpp>
+#include <nano/secure/vote.hpp>
 
 #include <boost/algorithm/string.hpp>
 #include <boost/property_tree/json_parser.hpp>

nano/rpc_test/rpc.cpp

@@ -25,6 +25,7 @@
 #include <nano/secure/ledger.hpp>
 #include <nano/secure/ledger_set_any.hpp>
 #include <nano/secure/ledger_set_confirmed.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/chains.hpp>
 #include <nano/test_common/network.hpp>
 #include <nano/test_common/system.hpp>

nano/secure/common.hpp

@@ -8,10 +8,10 @@
 #include <nano/lib/numbers.hpp>
 #include <nano/lib/object_stream.hpp>
 #include <nano/lib/stats.hpp>
+#include <nano/lib/stream_fwd.hpp>
 #include <nano/lib/timer.hpp>
 #include <nano/lib/utility.hpp>
 #include <nano/secure/rep_weights.hpp>
-#include <nano/secure/vote.hpp>
 
 #include <array>
 #include <unordered_map>

nano/slow_test/node.cpp

@@ -16,6 +16,7 @@
 #include <nano/secure/ledger.hpp>
 #include <nano/secure/ledger_set_any.hpp>
 #include <nano/secure/ledger_set_confirmed.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/network.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>

nano/slow_test/vote_processor.cpp

@@ -1,6 +1,7 @@
 #include <nano/lib/blocks.hpp>
 #include <nano/node/transport/inproc.hpp>
 #include <nano/node/vote_processor.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>
 

nano/store/component.hpp

@@ -10,6 +10,7 @@
 
 #include <boost/endian/conversion.hpp>
 #include <boost/polymorphic_cast.hpp>
+#include <boost/property_tree/ptree.hpp>
 
 #include <stack>
 
@@ -25,10 +26,15 @@ namespace store
 	class peer;
 	class pending;
 	class pruned;
-	class version;
+	class read_transaction;
 	class rep_weight;
+	class transaction;
+	class version;
+	class write_transaction;
 }
 class ledger_cache;
+class ledger_constants;
+enum class tables;
 
 namespace store
 {
@@ -89,8 +95,8 @@ namespace store
 		virtual void rebuild_db (write_transaction const & transaction_a) = 0;
 
 		/** Not applicable to all sub-classes */
-		virtual void serialize_mdb_tracker (boost::property_tree::ptree &, std::chrono::milliseconds, std::chrono::milliseconds){};
-		virtual void serialize_memory_stats (boost::property_tree::ptree &) = 0;
+		virtual void serialize_mdb_tracker (::boost::property_tree::ptree &, std::chrono::milliseconds, std::chrono::milliseconds){};
+		virtual void serialize_memory_stats (::boost::property_tree::ptree &) = 0;
 
 		virtual bool init_error () const = 0;
 

nano/store/db_val.hpp

@@ -16,6 +16,7 @@ class account_info_v22;
 class block;
 class pending_info;
 class pending_key;
+class vote;
 }
 
 namespace nano::store

nano/test_common/testutil.cpp

@@ -10,6 +10,7 @@
 #include <nano/secure/ledger.hpp>
 #include <nano/secure/ledger_set_any.hpp>
 #include <nano/secure/ledger_set_confirmed.hpp>
+#include <nano/secure/vote.hpp>
 #include <nano/store/block.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>