dn724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix network.construction_with_specified_port (uses test network port) (#3714)

Browse source 
The test case network.construction_with_specified_port uses the test
network port as the test port but that means this test fails if there
is a test network node running on that machine.

Convert the test to use nano::get_available_port() to avoid that
problem.
This commit is contained in:
Dimitrios Siganos 2022-02-07 14:40:09 +00:00 • committed by GitHub
commit d17d2c4364
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
nano/core_test/network.cpp
View file

@ -56,7 +56,7 @@ TEST (network, tcp_connection)
TEST (network, construction_with_specified_port) TEST (network, construction_with_specified_port)
{ {
nano::system system{}; nano::system system{};
auto const port = nano::test_node_port (); auto const port = nano::get_available_port ();
auto const node = system.add_node (nano::node_config{ port, system.logging }); auto const node = system.add_node (nano::node_config{ port, system.logging });
EXPECT_EQ (port, node->network.port); EXPECT_EQ (port, node->network.port);
EXPECT_EQ (port, node->network.endpoint ().port ()); EXPECT_EQ (port, node->network.endpoint ().port ());