dn724/dncurrency
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Dead code tcp_channels::modify

Browse source
This commit is contained in:
Piotr Wójcik 2024-05-03 11:44:28 +02:00
commit d30dcea56b
3 changed files with 2 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

8
nano/core_test/peer_container.cpp
View file

@ -79,16 +79,12 @@ TEST (peer_container, tcp_channel_cleanup_works)
ASSERT_NE (nullptr, channel1); ASSERT_NE (nullptr, channel1);
// set the last packet sent for channel1 only to guarantee it contains a value. // set the last packet sent for channel1 only to guarantee it contains a value.
// it won't be necessarily the same use by the cleanup cutoff time // it won't be necessarily the same use by the cleanup cutoff time
node1.network.tcp_channels.modify (channel1, [&now] (auto channel) { channel1->set_last_packet_sent (now - std::chrono::seconds (5));
channel->set_last_packet_sent (now - std::chrono::seconds (5));
});
auto channel2 = nano::test::establish_tcp (system, node1, outer_node2->network.endpoint ()); auto channel2 = nano::test::establish_tcp (system, node1, outer_node2->network.endpoint ());
ASSERT_NE (nullptr, channel2); ASSERT_NE (nullptr, channel2);
// set the last packet sent for channel2 only to guarantee it contains a value. // set the last packet sent for channel2 only to guarantee it contains a value.
// it won't be necessarily the same use by the cleanup cutoff time // it won't be necessarily the same use by the cleanup cutoff time
node1.network.tcp_channels.modify (channel2, [&now] (auto channel) { channel2->set_last_packet_sent (now + std::chrono::seconds (1));
channel->set_last_packet_sent (now + std::chrono::seconds (1));
});
ASSERT_EQ (2, node1.network.size ()); ASSERT_EQ (2, node1.network.size ());
ASSERT_EQ (2, node1.network.tcp_channels.size ()); ASSERT_EQ (2, node1.network.tcp_channels.size ());

12
nano/node/transport/tcp_channels.cpp
View file

@ -417,18 +417,6 @@ void nano::transport::tcp_channels::list (std::deque<std::shared_ptr<nano::trans
// clang-format on // clang-format on
} }
void nano::transport::tcp_channels::modify (std::shared_ptr<nano::transport::tcp_channel> const & channel_a, std::function<void (std::shared_ptr<nano::transport::tcp_channel> const &)> modify_callback_a)
{
nano::lock_guard<nano::mutex> lock{ mutex };
auto existing (channels.get<endpoint_tag> ().find (channel_a->get_tcp_endpoint ()));
if (existing != channels.get<endpoint_tag> ().end ())
{
channels.get<endpoint_tag> ().modify (existing, [modify_callback = std::move (modify_callback_a)] (channel_entry & wrapper_a) {
modify_callback (wrapper_a.channel);
});
}
}
void nano::transport::tcp_channels::start_tcp (nano::endpoint const & endpoint) void nano::transport::tcp_channels::start_tcp (nano::endpoint const & endpoint)
{ {
node.tcp_listener.connect (endpoint.address (), endpoint.port ()); node.tcp_listener.connect (endpoint.address (), endpoint.port ());

1
nano/node/transport/tcp_channels.hpp
View file

@ -50,7 +50,6 @@ public:
bool track_reachout (nano::endpoint const &); bool track_reachout (nano::endpoint const &);
void purge (std::chrono::steady_clock::time_point cutoff_deadline); void purge (std::chrono::steady_clock::time_point cutoff_deadline);
void list (std::deque<std::shared_ptr<nano::transport::channel>> &, uint8_t = 0, bool = true); void list (std::deque<std::shared_ptr<nano::transport::channel>> &, uint8_t = 0, bool = true);
void modify (std::shared_ptr<nano::transport::tcp_channel> const &, std::function<void (std::shared_ptr<nano::transport::tcp_channel> const &)>);
void keepalive (); void keepalive ();
std::optional<nano::keepalive> sample_keepalive (); std::optional<nano::keepalive> sample_keepalive ();