From f25037ea5aa07646e17aa80493a2a6db0438ed12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Wo=CC=81jcik?= <3044353+pwojcikdev@users.noreply.github.com> Date: Tue, 6 Aug 2024 18:04:30 +0200 Subject: [PATCH] Ignore telemetry requests --- nano/node/message_processor.cpp | 10 +--------- nano/node/nodeconfig.hpp | 2 +- nano/node/telemetry.hpp | 2 +- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/nano/node/message_processor.cpp b/nano/node/message_processor.cpp index dc1684789..4e82a23ee 100644 --- a/nano/node/message_processor.cpp +++ b/nano/node/message_processor.cpp @@ -242,15 +242,7 @@ public: void telemetry_req (nano::telemetry_req const & message) override { - // Send an empty telemetry_ack if we do not want, just to acknowledge that we have received the message to - // remove any timeouts on the server side waiting for a message. - nano::telemetry_ack telemetry_ack{ node.network_params.network }; - if (!node.flags.disable_providing_telemetry_metrics) - { - auto telemetry_data = node.local_telemetry (); - telemetry_ack = nano::telemetry_ack{ node.network_params.network, telemetry_data }; - } - channel->send (telemetry_ack, nullptr, nano::transport::buffer_drop_policy::no_socket_drop); + // Ignore telemetry requests as telemetry is being periodically broadcasted since V25+ } void telemetry_ack (nano::telemetry_ack const & message) override diff --git a/nano/node/nodeconfig.hpp b/nano/node/nodeconfig.hpp index be7772dfe..2f8b508da 100644 --- a/nano/node/nodeconfig.hpp +++ b/nano/node/nodeconfig.hpp @@ -191,7 +191,7 @@ public: bool disable_request_loop{ false }; // For testing only bool disable_tcp_realtime{ false }; bool disable_providing_telemetry_metrics{ false }; - bool disable_ongoing_telemetry_requests{ false }; + bool disable_ongoing_telemetry_requests{ true }; bool disable_block_processor_unchecked_deletion{ false }; bool disable_block_processor_republishing{ false }; bool allow_bootstrap_peers_duplicates{ false }; diff --git a/nano/node/telemetry.hpp b/nano/node/telemetry.hpp index 55bd8aaf7..f53bffea1 100644 --- a/nano/node/telemetry.hpp +++ b/nano/node/telemetry.hpp @@ -46,7 +46,7 @@ class telemetry public: struct config { - bool enable_ongoing_requests{ true }; + bool enable_ongoing_requests{ false }; bool enable_ongoing_broadcasts{ true }; config (nano::node_config const & config, nano::node_flags const & flags) :