[PORT] Fix a number of typescript issues (gitea#32308)
- Prefer [window.location.assign](https://developer.mozilla.org/en-US/docs/Web/API/Location/assign) over assigning to [window.location](https://developer.mozilla.org/en-US/docs/Web/API/Window/location) which typescript does not like. This works in all browsers including PaleMoon. - Fix all typescript issues in `web_src/js/webcomponents`, no behaviour changes. - ~~Workaround bug in `@typescript-eslint/no-unnecessary-type-assertion` rule.~~ - Omit vendored file from type checks. - `tsc` error count is reduce by 53 with these changes. --- Conflict resolution: Choose our version. Done differently: Everything related to typescript types isn't ported. Use `window.location.href` instead of `String(window.location)`, thanks @viceice! (cherry picked from commit 810782302652d73c4f7249c4c3df8a7e85bae5f0)
This commit is contained in:
parent
20c0a2a381
commit
3bdca4615c
3 changed files with 10 additions and 10 deletions
|
@ -119,7 +119,7 @@ function excludeLabel(item) {
|
|||
const regStr = `labels=((?:-?[0-9]+%2c)*)(${id})((?:%2c-?[0-9]+)*)&`;
|
||||
const newStr = 'labels=$1-$2$3&';
|
||||
|
||||
window.location = href.replace(new RegExp(regStr), newStr);
|
||||
window.location.assign(href.replace(new RegExp(regStr), newStr));
|
||||
}
|
||||
|
||||
export function initRepoIssueSidebarList() {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue