[PORT] Fix a number of typescript issues (gitea#32308)
- Prefer [window.location.assign](https://developer.mozilla.org/en-US/docs/Web/API/Location/assign) over assigning to [window.location](https://developer.mozilla.org/en-US/docs/Web/API/Window/location) which typescript does not like. This works in all browsers including PaleMoon. - Fix all typescript issues in `web_src/js/webcomponents`, no behaviour changes. - ~~Workaround bug in `@typescript-eslint/no-unnecessary-type-assertion` rule.~~ - Omit vendored file from type checks. - `tsc` error count is reduce by 53 with these changes. --- Conflict resolution: Choose our version. Done differently: Everything related to typescript types isn't ported. Use `window.location.href` instead of `String(window.location)`, thanks @viceice! (cherry picked from commit 810782302652d73c4f7249c4c3df8a7e85bae5f0)
This commit is contained in:
parent
20c0a2a381
commit
3bdca4615c
3 changed files with 10 additions and 10 deletions
|
@ -1,9 +1,9 @@
|
|||
import {toOriginUrl} from './origin-url.js';
|
||||
|
||||
test('toOriginUrl', () => {
|
||||
const oldLocation = window.location;
|
||||
const oldLocation = window.location.href;
|
||||
for (const origin of ['https://example.com', 'https://example.com:3000']) {
|
||||
window.location = new URL(`${origin}/`);
|
||||
window.location.assign(`${origin}/`);
|
||||
expect(toOriginUrl('/')).toEqual(`${origin}/`);
|
||||
expect(toOriginUrl('/org/repo.git')).toEqual(`${origin}/org/repo.git`);
|
||||
expect(toOriginUrl('https://another.com')).toEqual(`${origin}/`);
|
||||
|
@ -13,5 +13,5 @@ test('toOriginUrl', () => {
|
|||
expect(toOriginUrl('https://another.com:4000/')).toEqual(`${origin}/`);
|
||||
expect(toOriginUrl('https://another.com:4000/org/repo.git')).toEqual(`${origin}/org/repo.git`);
|
||||
}
|
||||
window.location = oldLocation;
|
||||
window.location.assign(oldLocation);
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue