From 511148dbc3b18df56cef1dfd2f0f84b88930684c Mon Sep 17 00:00:00 2001 From: Gusted Date: Mon, 17 Mar 2025 09:00:12 +0000 Subject: [PATCH] perf: avoid sorting team names for `ComposeMetas` (#7223) - `ComposeMetas` is called to compose meta information for the markdown processer (which is called a lot), one of those information is the team names that have access to the repository. This is used to decide if a mention is a team mention or not. - The SQL query sorts the names, this is unnecessary and not required for within the processer; it does a simple `strings.Contains(teams, ","+teamName+",")`, which doesn't rely on sorted values. - Doing the SQL query with sorting against Codeberg's MariaDB took ~0.180s and without sorting took ~0.03s. Although the returned values are often a few rows (the query I tested returned 8 values) it seems that doing any sorting will create an temporary index and is mainly optimized where it has to sort a huge amount of rows. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7223 Reviewed-by: 0ko <0ko@noreply.codeberg.org> Reviewed-by: Otto Co-authored-by: Gusted Co-committed-by: Gusted --- models/repo/repo.go | 1 - 1 file changed, 1 deletion(-) diff --git a/models/repo/repo.go b/models/repo/repo.go index bdf0de2f85..ca7d50ca6a 100644 --- a/models/repo/repo.go +++ b/models/repo/repo.go @@ -529,7 +529,6 @@ func (repo *Repository) ComposeMetas(ctx context.Context) map[string]string { Join("INNER", "team", "team.id = team_repo.team_id"). Where("team_repo.repo_id = ?", repo.ID). Select("team.lower_name"). - OrderBy("team.lower_name"). Find(&teams) metas["teams"] = "," + strings.Join(teams, ",") + "," metas["org"] = strings.ToLower(repo.OwnerName)