git724/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Issue popup message that the issue doesn't exist

Browse source 
Signed-off-by: Minecon724 <minecon724@noreply.git.m724.eu>
This commit is contained in:
Minecon724 2025-03-17 13:37:59 +01:00
parent 22a74730d3
commit 6f2a441ed5
Signed by: Minecon724
GPG key ID: A02E6E67AB961189
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
options/locale/locale_en-US.ini
View file

@ -247,6 +247,7 @@ report_message = If you believe that this is a Forgejo bug, please search for is
not_found = The target couldn't be found. not_found = The target couldn't be found.
network_error = Network error network_error = Network error
server_internal = Internal server error server_internal = Internal server error
issue_not_found = Issue doesn't exist
[startpage] [startpage]
app_desc = A painless, self-hosted Git service app_desc = A painless, self-hosted Git service

6
routers/web/repo/issue.go
View file

@ -2218,7 +2218,7 @@ func GetIssueInfo(ctx *context.Context) {
issue, err := issues_model.GetIssueWithAttrsByIndex(ctx, ctx.Repo.Repository.ID, ctx.ParamsInt64(":index")) issue, err := issues_model.GetIssueWithAttrsByIndex(ctx, ctx.Repo.Repository.ID, ctx.ParamsInt64(":index"))
if err != nil { if err != nil {
if issues_model.IsErrIssueNotExist(err) { if issues_model.IsErrIssueNotExist(err) {
ctx.Error(http.StatusNotFound) ctx.Error(http.StatusNotFound, ctx.Locale.TrString("error.issue_not_found"))
} else { } else {
ctx.Error(http.StatusInternalServerError, "GetIssueByIndex", err.Error()) ctx.Error(http.StatusInternalServerError, "GetIssueByIndex", err.Error())
} }
@ -2228,13 +2228,13 @@ func GetIssueInfo(ctx *context.Context) {
if issue.IsPull { if issue.IsPull {
// Need to check if Pulls are enabled and we can read Pulls // Need to check if Pulls are enabled and we can read Pulls
if !ctx.Repo.Repository.CanEnablePulls() || !ctx.Repo.CanRead(unit.TypePullRequests) { if !ctx.Repo.Repository.CanEnablePulls() || !ctx.Repo.CanRead(unit.TypePullRequests) {
ctx.Error(http.StatusNotFound) ctx.Error(http.StatusNotFound, ctx.Locale.TrString("error.issue_not_found"))
return return
} }
} else { } else {
// Need to check if Issues are enabled and we can read Issues // Need to check if Issues are enabled and we can read Issues
if !ctx.Repo.CanRead(unit.TypeIssues) { if !ctx.Repo.CanRead(unit.TypeIssues) {
ctx.Error(http.StatusNotFound) ctx.Error(http.StatusNotFound, ctx.Locale.TrString("error.issue_not_found"))
return return
} }
} }