chore(branding): strip metadata information from the footer

When the Forgejo version is displayed in the footer, the metadata
should not be displayed. It was once an indication that Forgejo
includes all of Gitea. But since the hard fork the codebase diverged
and this is no longer accurate.

The metadata is still displayed in the API, admin panels or headers
for the sake of backward compatibility.

Refs: https://codeberg.org/forgejo/discussions/issues/244
(cherry picked from commit 2c81893c76)

modules/templates/helper.go

@@ -103,6 +103,10 @@ func NewFuncMap() template.FuncMap {
 		"AppVer": func() string {
 			return setting.AppVer
 		},
+		"AppVerNoMetadata": func() string {
+			version, _, _ := strings.Cut(setting.AppVer, "+")
+			return version
+		},
 		"AppDomain": func() string { // documented in mail-templates.md
 			return setting.Domain
 		},

templates/base/footer_content.tmpl

@@ -8,7 +8,7 @@
 			{{if .IsAdmin}}
 				<a href="{{AppSubUrl}}/admin/config">{{AppVer}}</a>
 			{{else}}
-				{{AppVer}}
+				{{AppVerNoMetadata}}
 			{{end}}
 		{{end}}
 		{{if and .TemplateLoadTimes ShowFooterTemplateLoadTime}}

templates/status/404.tmpl

@@ -8,7 +8,7 @@
 
 		<div class="divider"></div>
 		<br>
-		{{if .ShowFooterVersion}}<p>{{ctx.Locale.Tr "admin.config.app_ver"}}: {{AppVer}}</p>{{end}}
+		{{if .ShowFooterVersion}}<p>{{ctx.Locale.Tr "admin.config.app_ver"}}: {{AppVerNoMetadata}}</p>{{end}}
 	</div>
 </div>
 {{template "base/footer" .}}