git724/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Refactor install page (db type) (#17919)

Browse source 
* Refactor install page (db type)

* set correct default DB HOST for different DB TYPE
* remove legacy TiDB from documents
* unify the usage of DB TYPE, in code we only use "mysql". "MySQL" is only shown to users for friendly name.

* Gitea can use TiDB via MySQL protocol

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
wxiaoguang 2021-12-07 13:44:08 +08:00 • committed by GitHub
parent b30870ef8b
commit a6f961fba4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 75 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

63
web_src/js/features/install.js
View file

@ -1,50 +1,41 @@
export function initInstall() {
if ($('.install').length === 0) {
if ($('.page-content.install').length === 0) {
return;
}
if ($('#db_host').val() === '') {
$('#db_host').val('127.0.0.1:3306');
$('#db_user').val('gitea');
$('#db_name').val('gitea');
}
const defaultDbUser = 'gitea';
const defaultDbName = 'gitea';
const defaultDbHosts = {
mysql: '127.0.0.1:3306',
postgres: '127.0.0.1:5432',
mssql: '127.0.0.1:1433'
};
const $dbHost = $('#db_host');
const $dbUser = $('#db_user');
const $dbName = $('#db_name');
// Database type change detection.
$('#db_type').on('change', function () {
const sqliteDefault = 'data/gitea.db';
const tidbDefault = 'data/gitea_tidb';
const dbType = $(this).val();
if (dbType === 'SQLite3') {
$('#sql_settings').hide();
$('#pgsql_settings').hide();
$('#mysql_settings').hide();
$('#sqlite_settings').show();
$('div[data-db-setting-for]').hide();
$(`div[data-db-setting-for=${dbType}]`).show();
if (dbType === 'SQLite3' && $('#db_path').val() === tidbDefault) {
$('#db_path').val(sqliteDefault);
if (dbType !== 'sqlite3') {
// for most remote database servers
$(`div[data-db-setting-for=common-host]`).show();
const lastDbHost = $dbHost.val();
const isDbHostDefault = !lastDbHost || Object.values(defaultDbHosts).includes(lastDbHost);
if (isDbHostDefault) {
$dbHost.val(defaultDbHosts[dbType] ?? '');
}
return;
}
const dbDefaults = {
MySQL: '127.0.0.1:3306',
PostgreSQL: '127.0.0.1:5432',
MSSQL: '127.0.0.1:1433'
};
$('#sqlite_settings').hide();
$('#sql_settings').show();
$('#pgsql_settings').toggle(dbType === 'PostgreSQL');
$('#mysql_settings').toggle(dbType === 'MySQL');
$.each(dbDefaults, (_type, defaultHost) => {
if ($('#db_host').val() === defaultHost) {
$('#db_host').val(dbDefaults[dbType]);
return false;
if (!$dbUser.val() && !$dbName.val()) {
$dbUser.val(defaultDbUser);
$dbName.val(defaultDbName);
}
});
});
} // else: for SQLite3, the default path is always prepared by backend code (setting)
}).trigger('change');
// TODO: better handling of exclusive relations.
$('#offline-mode input').on('change', function () {