git724/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Enforce trailing comma in JS on multiline (#30002)

Browse source 
To keep blame info accurate and to avoid [changes like
this](https://github.com/go-gitea/gitea/pull/29977/files#diff-c3422631a14edbe1e508c4b22f0c718db318be08a6e889427802f9b6165d88d6R359),
it's good to always have a trailing comma, so let's enforce it in JS.

This rule is completely automatically fixable with `make lint-js-fix`
and that's what I did here.

(cherry picked from commit 3d751b6ec18e57698ce86b79866031d2c80c2071)

Conflicts:
	web_src/js/components/DashboardRepoList.vue
	trivial context conflict because of '3b7b899afa fix commit_status'
This commit is contained in:
silverwind 2024-03-22 15:06:53 +01:00 • committed by Earl Warren
parent 9c9f40f6d3
commit b96845ae01
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
48 changed files with 117 additions and 117 deletions
Download patch file Download diff file Expand all files Collapse all files

10
web_src/js/components/ActionRunStatus.vue
View file

@ -10,20 +10,20 @@ export default {
props: {
status: {
type: String,
required: true
required: true,
},
size: {
type: Number,
default: 16
default: 16,
},
className: {
type: String,
default: ''
default: '',
},
localeStatus: {
type: String,
default: ''
}
default: '',
},
},
};
</script>

4
web_src/js/components/ActivityHeatmap.vue
View file

@ -11,7 +11,7 @@ export default {
locale: {
type: Object,
default: () => {},
}
},
},
data: () => ({
colorRange: [
@ -49,7 +49,7 @@ export default {
const newSearch = params.toString();
window.location.search = newSearch.length ? `?${newSearch}` : '';
}
},
},
};
</script>

6
web_src/js/components/ContextPopup.vue
View file

@ -69,7 +69,7 @@ export default {
}
return {name: label.name, color: `#${label.color}`, textColor};
});
}
},
},
mounted() {
this.$refs.root.addEventListener('ce-load-context-popup', (e) => {
@ -97,8 +97,8 @@ export default {
} finally {
this.loading = false;
}
}
}
},
},
};
</script>
<template>

4
web_src/js/components/DashboardRepoList.vue
View file

@ -252,7 +252,7 @@ const sfc = {
return {
...webSearchRepo.repository,
latest_commit_status: webSearchRepo.latest_commit_status,
locale_latest_commit_status_state: webSearchRepo.locale_latest_commit_status
locale_latest_commit_status: webSearchRepo.locale_latest_commit_status,
};
});
const count = response.headers.get('X-Total-Count');
@ -324,7 +324,7 @@ const sfc = {
if (this.activeIndex === -1 || this.activeIndex > this.repos.length - 1) {
this.activeIndex = 0;
}
}
},
},
};

6
web_src/js/components/DiffCommitSelector.vue
View file

@ -14,7 +14,7 @@ export default {
},
commits: [],
hoverActivated: false,
lastReviewCommitSha: null
lastReviewCommitSha: null,
};
},
computed: {
@ -29,7 +29,7 @@ export default {
},
issueLink() {
return this.$el.parentNode.getAttribute('data-issuelink');
}
},
},
mounted() {
document.body.addEventListener('click', this.onBodyClick);
@ -185,7 +185,7 @@ export default {
}
}
},
}
},
};
</script>
<template>

2
web_src/js/components/DiffFileList.vue
View file

@ -31,7 +31,7 @@ export default {
},
loadMoreData() {
loadMoreFiles(this.store.linkLoadMore);
}
},
},
};
</script>

6
web_src/js/components/DiffFileTree.vue
View file

@ -30,7 +30,7 @@ export default {
let newParent = {
name: split,
children: [],
isFile
isFile,
};
if (isFile === true) {
@ -40,7 +40,7 @@ export default {
if (parent) {
// check if the folder already exists
const existingFolder = parent.children.find(
(x) => x.name === split
(x) => x.name === split,
);
if (existingFolder) {
newParent = existingFolder;
@ -74,7 +74,7 @@ export default {
// reduce the depth of our tree.
mergeChildIfOnlyOneDir(result);
return result;
}
},
},
mounted() {
// Default to true if unset

2
web_src/js/components/DiffFileTreeItem.vue
View file

@ -7,7 +7,7 @@ export default {
props: {
item: {
type: Object,
required: true
required: true,
},
},
data: () => ({

2
web_src/js/components/PullRequestMergeForm.vue
View file

@ -43,7 +43,7 @@ export default {
for (const elem of document.querySelectorAll('[data-pull-merge-style]')) {
toggleElem(elem, elem.getAttribute('data-pull-merge-style') === val);
}
}
},
},
created() {
this.mergeStyleAllowedCount = this.mergeForm.mergeStyles.reduce((v, msd) => v + (msd.allowed ? 1 : 0), 0);

6
web_src/js/components/RepoActionView.vue
View file

@ -69,7 +69,7 @@ const sfc = {
name: '',
link: '',
},
}
},
},
currentJob: {
title: '',
@ -314,7 +314,7 @@ const sfc = {
const logLine = this.$refs.steps.querySelector(selectedLogStep);
if (!logLine) return;
logLine.querySelector('.line-num').click();
}
},
},
};
@ -357,7 +357,7 @@ export function initRepositoryActionView() {
skipped: el.getAttribute('data-locale-status-skipped'),
blocked: el.getAttribute('data-locale-status-blocked'),
},
}
},
});
view.mount(el);
}

2
web_src/js/components/RepoActivityTopAuthors.vue
View file

@ -47,7 +47,7 @@ const sfc = {
this.colors.barColor = refStyle.backgroundColor;
this.colors.textColor = refStyle.color;
this.colors.textAltColor = refAltStyle.color;
}
},
};
export function initRepoActivityTopAuthorsChart() {

6
web_src/js/components/RepoBranchTagSelector.vue
View file

@ -36,7 +36,7 @@ const sfc = {
},
shouldCreateTag() {
return this.mode === 'tags';
}
},
},
watch: {
@ -45,7 +45,7 @@ const sfc = {
this.focusSearchField();
this.fetchBranchesOrTags();
}
}
},
},
beforeMount() {
@ -209,7 +209,7 @@ const sfc = {
this.isLoading = false;
}
},
}
},
};
export function initRepoBranchTagSelector(selector) {

6
web_src/js/components/RepoCodeFrequency.vue
View file

@ -39,7 +39,7 @@ export default {
props: {
locale: {
type: Object,
required: true
required: true,
},
},
data: () => ({
@ -128,12 +128,12 @@ export default {
},
ticks: {
maxRotation: 0,
maxTicksLimit: 12
maxTicksLimit: 12,
},
},
y: {
ticks: {
maxTicksLimit: 6
maxTicksLimit: 6,
},
},
},

8
web_src/js/components/RepoContributors.vue
View file

@ -34,7 +34,7 @@ const customEventListener = {
chart.resetZoom();
opts.instance.updateOtherCharts(args.event, true);
}
}
},
};
Chart.defaults.color = chartJsColors.text;
@ -82,7 +82,7 @@ export default {
this.xAxisMax = this.xAxisEnd;
this.type = val;
this.sortContributors();
}
},
});
},
methods: {
@ -175,7 +175,7 @@ export default {
// Normally, chartjs handles this automatically, but it will resize the graph when you
// zoom, pan etc. I think resizing the graph makes it harder to compare things visually.
const maxValue = Math.max(
...this.totalStats.weeks.map((o) => o[this.type])
...this.totalStats.weeks.map((o) => o[this.type]),
);
const [coefficient, exp] = maxValue.toExponential().split('e').map(Number);
if (coefficient % 1 === 0) return maxValue;
@ -187,7 +187,7 @@ export default {
// for contributors' graph. If I let chartjs do this for me, it will choose different
// maxY value for each contributors' graph which again makes it harder to compare.
const maxValue = Math.max(
...this.sortedContributors.map((c) => c.max_contribution_type)
...this.sortedContributors.map((c) => c.max_contribution_type),
);
const [coefficient, exp] = maxValue.toExponential().split('e').map(Number);
if (coefficient % 1 === 0) return maxValue;

6
web_src/js/components/RepoRecentCommits.vue
View file

@ -35,7 +35,7 @@ export default {
props: {
locale: {
type: Object,
required: true
required: true,
},
},
data: () => ({
@ -105,12 +105,12 @@ export default {
},
ticks: {
maxRotation: 0,
maxTicksLimit: 52
maxTicksLimit: 52,
},
},
y: {
ticks: {
maxTicksLimit: 6
maxTicksLimit: 6,
},
},
},

4
web_src/js/components/ScopedAccessTokenSelector.vue
View file

@ -39,7 +39,7 @@ const sfc = {
'repository',
'user');
return categories;
}
},
},
mounted() {
@ -68,7 +68,7 @@ const sfc = {
}
// no scopes selected, show validation error
showElem(warningEl);
}
},
},
};