diff --git a/eslint.config.mjs b/eslint.config.mjs index ac4d0aa261..83a6b6bee1 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -799,6 +799,7 @@ export default tseslint.config( 'unicorn/prefer-array-some': [2], 'unicorn/prefer-at': [0], 'unicorn/prefer-blob-reading-methods': [2], + 'unicorn/prefer-classlist-toggle': [2], 'unicorn/prefer-code-point': [0], 'unicorn/prefer-date-now': [2], 'unicorn/prefer-default-parameters': [0], diff --git a/package-lock.json b/package-lock.json index f73f46b9d0..98a7e3ff4c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -81,7 +81,7 @@ "eslint-plugin-regexp": "2.10.0", "eslint-plugin-sonarjs": "3.0.4", "eslint-plugin-toml": "0.12.0", - "eslint-plugin-unicorn": "60.0.0", + "eslint-plugin-unicorn": "61.0.1", "eslint-plugin-vitest-globals": "1.5.0", "eslint-plugin-vue": "10.4.0", "eslint-plugin-vue-scoped-css": "2.11.0", @@ -7659,9 +7659,9 @@ } }, "node_modules/eslint-plugin-unicorn": { - "version": "60.0.0", - "resolved": "https://registry.npmjs.org/eslint-plugin-unicorn/-/eslint-plugin-unicorn-60.0.0.tgz", - "integrity": "sha512-QUzTefvP8stfSXsqKQ+vBQSEsXIlAiCduS/V1Em+FKgL9c21U/IIm20/e3MFy1jyCf14tHAhqC1sX8OTy6VUCg==", + "version": "61.0.1", + "resolved": "https://registry.npmjs.org/eslint-plugin-unicorn/-/eslint-plugin-unicorn-61.0.1.tgz", + "integrity": "sha512-RwXXqS8oTxW7dVs6e4ZBpZkn1wB4qqNZSbCJektP8/Nzp/woJdfN/t7LVNcpGMZ57xWBs33K0ymZ7MV+VeQnbA==", "dev": true, "license": "MIT", "dependencies": { diff --git a/package.json b/package.json index b1ac14a880..b06a37a3fd 100644 --- a/package.json +++ b/package.json @@ -80,7 +80,7 @@ "eslint-plugin-regexp": "2.10.0", "eslint-plugin-sonarjs": "3.0.4", "eslint-plugin-toml": "0.12.0", - "eslint-plugin-unicorn": "60.0.0", + "eslint-plugin-unicorn": "61.0.1", "eslint-plugin-vitest-globals": "1.5.0", "eslint-plugin-vue": "10.4.0", "eslint-plugin-vue-scoped-css": "2.11.0", diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue index 9f47d45bc0..24bc32e348 100644 --- a/web_src/js/components/RepoActionView.vue +++ b/web_src/js/components/RepoActionView.vue @@ -198,11 +198,7 @@ const sfc = { toggleGroupLogs(event) { const line = event.target.parentElement; const list = line.nextSibling; - if (event.newState === 'open') { - list.classList.remove('hidden'); - } else { - list.classList.add('hidden'); - } + list.classList.toggle('hidden', event.newState !== 'open'); }, createLogLine(line, startTime, stepIndex, group) { diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js index a6c2829b53..90f5c11989 100644 --- a/web_src/js/features/common-global.js +++ b/web_src/js/features/common-global.js @@ -248,11 +248,7 @@ export async function initDropzone(dropzoneEl, zone = undefined) { file.previewTemplate.append(copyLinkElement); }; const updateDropzoneState = () => { - if (dropzoneEl.querySelector('.dz-preview')) { - dropzoneEl.classList.add('dz-started'); - } else { - dropzoneEl.classList.remove('dz-started'); - } + dropzoneEl.classList.toggle('dz-started', dropzoneEl.querySelector('.dz-preview')); }; const dz = await createDropzone(dropzoneEl, { diff --git a/web_src/js/features/comp/LabelEdit.js b/web_src/js/features/comp/LabelEdit.js index a97c7fe34c..2b13c64344 100644 --- a/web_src/js/features/comp/LabelEdit.js +++ b/web_src/js/features/comp/LabelEdit.js @@ -13,11 +13,7 @@ function updateExclusiveLabelEdit(form) { if (isExclusiveScopeName(nameInput.value)) { exclusiveField?.classList.remove('muted'); exclusiveField?.removeAttribute('aria-disabled'); - if (exclusiveCheckbox.checked && exclusiveCheckbox.getAttribute('data-exclusive-warn')) { - exclusiveWarning?.classList.remove('tw-hidden'); - } else { - exclusiveWarning?.classList.add('tw-hidden'); - } + exclusiveWarning?.classList.toggle('tw-hidden', !(exclusiveCheckbox.checked && exclusiveCheckbox.getAttribute('data-exclusive-warn'))); } else { exclusiveField?.classList.add('muted'); exclusiveField?.setAttribute('aria-disabled', 'true');