git724/forgejo
1
0
Fork 0
Code Issues Pull requests 3 Projects 1 Releases Packages Wiki Activity

[v12.0/forgejo] fix(ui): clear fields when canceling adding ssh key (#9112)

Browse source 
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/8990

- Add javascript to clear fields upon clicking the cancel button inside the panel for adding new SSH keys.
- Add E2E test.
- Resolves #8915

Co-authored-by: dawe <dawedawe@posteo.de>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9112
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
Co-committed-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
This commit is contained in:
forgejo-backport-action 2025-09-02 08:00:46 +02:00 • committed by Gusted
commit c897e40d4f
3 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/e2e/user-settings.test.e2e.ts
View file

@ -78,3 +78,21 @@ test('User: Storage overview', async ({browser}, workerInfo) => {
await expect(page.getByText('Git LFS')).toBeVisible();
await save_visual(page);
});
test('User: Canceling adding SSH key clears inputs', async ({browser}, workerInfo) => {
const page = await login({browser}, workerInfo);
await page.goto('/user/settings/keys');
await page.locator('#add-ssh-button').click();
await page.getByLabel('Key name').fill('MyAwesomeKey');
await page.locator('#ssh-key-content').fill('Wront key material');
await page.getByRole('button', {name: 'Cancel'}).click();
await page.locator('#add-ssh-button').click();
const keyName = page.getByLabel('Key name');
await expect(keyName).toHaveValue('');
const content = page.locator('#ssh-key-content');
await expect(content).toHaveValue('');
});

7
web_src/js/features/sshkey-helper.js
View file

@ -8,3 +8,10 @@ export function initSshKeyFormParser() {
}
});
}
export function initSshKeyCancelButton() {
document.getElementById('cancel-ssh-button')?.addEventListener('click', () => {
document.getElementById('ssh-key-title').value = '';
document.getElementById('ssh-key-content').value = '';
});
}

3
web_src/js/index.js
View file

@ -51,7 +51,7 @@ import {initAdminEmails} from './features/admin/emails.js';
import {initAdminCommon} from './features/admin/common.js';
import {initRepoTemplateSearch} from './features/repo-template.js';
import {initRepoCodeView} from './features/repo-code.js';
import {initSshKeyFormParser} from './features/sshkey-helper.js';
import {initSshKeyFormParser, initSshKeyCancelButton} from './features/sshkey-helper.js';
import {initRepoArchiveLinks} from './features/repo-common.js';
import {initRepoMigrationStatusChecker} from './features/repo-migrate.js';
import {
@ -124,6 +124,7 @@ onDomReady(() => {
initMarkupAnchors();
initMarkupContent();
initSshKeyFormParser();
initSshKeyCancelButton();
initStopwatch();
initTableSort();
initAutoFocusEnd();