Fix: http: multiple response.WriteHeader calls (#2038)
		
	We can't change the http status code here, because the response has been written.
This commit is contained in:
		
					parent
					
						
							
								32fc44aa83
							
						
					
				
			
			
				commit
				
					
						d389ed25a5
					
				
			
		
					 1 changed files with 0 additions and 1 deletions
				
			
		| 
						 | 
				
			
			@ -381,7 +381,6 @@ func serviceRPC(h serviceHandler, service string) {
 | 
			
		|||
	cmd.Stderr = &stderr
 | 
			
		||||
	if err := cmd.Run(); err != nil {
 | 
			
		||||
		log.GitLogger.Error(2, "fail to serve RPC(%s): %v - %v", service, err, stderr)
 | 
			
		||||
		h.w.WriteHeader(http.StatusInternalServerError)
 | 
			
		||||
		return
 | 
			
		||||
	}
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue