git724/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Forbid variables containing jQuery collections not having the $ prefix (#29839)

Browse source 
See
https://github.com/wikimedia/eslint-plugin-no-jquery/blob/master/docs/rules/variable-pattern.md

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit 3cd64949ae1402a4ff45fba0a27c4acca1c5aead)
This commit is contained in:
Yarden Shoham 2024-03-16 14:22:16 +02:00 • committed by Earl Warren
parent 96e5d38b55
commit d5f44c2499
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
14 changed files with 192 additions and 192 deletions
Download patch file Download diff file Expand all files Collapse all files

20
web_src/js/features/notification.js
View file

@ -45,9 +45,9 @@ async function receiveUpdateCount(event) {
}
export function initNotificationCount() {
const notificationCount = $('.notification_count');
const $notificationCount = $('.notification_count');
if (!notificationCount.length) {
if (!$notificationCount.length) {
return;
}
@ -55,7 +55,7 @@ export function initNotificationCount() {
const startPeriodicPoller = (timeout, lastCount) => {
if (timeout <= 0 || !Number.isFinite(timeout)) return;
usingPeriodicPoller = true;
lastCount = lastCount ?? notificationCount.text();
lastCount = lastCount ?? $notificationCount.text();
setTimeout(async () => {
await updateNotificationCountWithCallback(startPeriodicPoller, timeout, lastCount);
}, timeout);
@ -143,8 +143,8 @@ async function updateNotificationCountWithCallback(callback, timeout, lastCount)
}
async function updateNotificationTable() {
const notificationDiv = $('#notification_div');
if (notificationDiv.length > 0) {
const $notificationDiv = $('#notification_div');
if ($notificationDiv.length > 0) {
try {
const params = new URLSearchParams(window.location.search);
params.set('div-only', true);
@ -158,7 +158,7 @@ async function updateNotificationTable() {
const data = await response.text();
if ($(data).data('sequence-number') === notificationSequenceNumber) {
notificationDiv.replaceWith(data);
$notificationDiv.replaceWith(data);
initNotificationsTable();
}
} catch (error) {
@ -177,14 +177,14 @@ async function updateNotificationCount() {
const data = await response.json();
const notificationCount = $('.notification_count');
const $notificationCount = $('.notification_count');
if (data.new === 0) {
notificationCount.addClass('gt-hidden');
$notificationCount.addClass('gt-hidden');
} else {
notificationCount.removeClass('gt-hidden');
$notificationCount.removeClass('gt-hidden');
}
notificationCount.text(`${data.new}`);
$notificationCount.text(`${data.new}`);
return `${data.new}`;
} catch (error) {