fix(ui): only run auth_name code on new and edit page (#7470)
- Only run the dynamic `auth_name` update code when its on the new or edit page. `.admin.authentication` also matches the main authentication screen which lead to a javascript error. - Regression of forgejo/forgejo#7408 # Testing 1. Login as a admin. 2. Go to `/admin/auths`. 3. Notice no errors. 4. Go to `admin/auths/new`. 6. Select 'OAuth2' as authentication type. 5. Type some input into the 'Authentication name'. 6. Notice the the callback URL in the 'Tips' section including the authentication name. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7470 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz>
This commit is contained in:
		
					parent
					
						
							
								b04bb28ed1
							
						
					
				
			
			
				commit
				
					
						e6c17f31be
					
				
			
		
					 1 changed files with 1 additions and 1 deletions
				
			
		| 
						 | 
				
			
			@ -199,7 +199,7 @@ export function initAdminCommon() {
 | 
			
		|||
    }
 | 
			
		||||
  }
 | 
			
		||||
 | 
			
		||||
  if (document.querySelector('.admin.authentication')) {
 | 
			
		||||
  if (document.querySelector('.admin.edit.authentication, .admin.new.authentication')) {
 | 
			
		||||
    const authNameEl = document.getElementById('auth_name');
 | 
			
		||||
    authNameEl.addEventListener('input', (el) => {
 | 
			
		||||
      // appSubUrl is either empty or is a path that starts with `/` and doesn't have a trailing slash.
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue