git724/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Improve accessibility when (re-)viewing files (#24817)

Browse source 
Visually, nothing should have changed.
Changes include
- Convert most `<a [no href]>` to `<button>` when (re-)viewing files:
- `<a [no href]>` are, by HTML definition, not a link and hence cannot
be focused
- `<a class="ui button">` can now be clicked (again?) using
<kbd>Enter</kbd>
- Previously, the installed keypress handler on `.ui.button` elements
disabled it for links somehow
- The `(un)escape file`, the `expand section` and the `expand/collapse
file` buttons can now be focused (and subsequently clicked using only
the keyboard)
- You can now press <kbd>Space</kbd> on a focused `View file` checkbox
to mark the file as viewed.
- previously, this was impossible as this checkbox listened on the wrong
event listener

The `add code comment` button has been left inaccessible for now as it
requires quite a bit of extra logic so that it is unhidden when it is
focused (you can otherwise focus it without seeing it as you are not
hovering on the corresponding line).

---------

Co-authored-by: silverwind <me@silverwind.io>
This commit is contained in:
delvh 2023-05-21 22:47:41 +02:00 • committed by GitHub
parent c59a057297
commit e95b42e187
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
17 changed files with 105 additions and 92 deletions
Download patch file Download diff file Expand all files Collapse all files

18
web_src/js/features/repo-unicode-escape.js
View file

@ -2,30 +2,30 @@ import $ from 'jquery';
import {hideElem, showElem} from '../utils/dom.js';
export function initUnicodeEscapeButton() {
$(document).on('click', 'a.escape-button', (e) => {
$(document).on('click', '.escape-button', (e) => {
e.preventDefault();
$(e.target).parents('.file-content, .non-diff-file-content').find('.file-code, .file-view').addClass('unicode-escaped');
hideElem($(e.target));
showElem($(e.target).siblings('a.unescape-button'));
showElem($(e.target).siblings('.unescape-button'));
});
$(document).on('click', 'a.unescape-button', (e) => {
$(document).on('click', '.unescape-button', (e) => {
e.preventDefault();
$(e.target).parents('.file-content, .non-diff-file-content').find('.file-code, .file-view').removeClass('unicode-escaped');
hideElem($(e.target));
showElem($(e.target).siblings('a.escape-button'));
showElem($(e.target).siblings('.escape-button'));
});
$(document).on('click', 'a.toggle-escape-button', (e) => {
$(document).on('click', '.toggle-escape-button', (e) => {
e.preventDefault();
const fileContent = $(e.target).parents('.file-content, .non-diff-file-content');
const fileView = fileContent.find('.file-code, .file-view');
if (fileView.hasClass('unicode-escaped')) {
fileView.removeClass('unicode-escaped');
hideElem(fileContent.find('a.unescape-button'));
showElem(fileContent.find('a.escape-button'));
hideElem(fileContent.find('.unescape-button'));
showElem(fileContent.find('.escape-button'));
} else {
fileView.addClass('unicode-escaped');
showElem(fileContent.find('a.unescape-button'));
hideElem(fileContent.find('a.escape-button'));
showElem(fileContent.find('.unescape-button'));
hideElem(fileContent.find('.escape-button'));
}
});
}