0a6a6d351d
Some checks are pending
/ release (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-e2e (push) Blocked by required conditions
testing / test-remote-cacher (redis) (push) Blocked by required conditions
testing / test-remote-cacher (valkey) (push) Blocked by required conditions
testing / test-remote-cacher (garnet) (push) Blocked by required conditions
testing / test-remote-cacher (redict) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/7344 - This makes the `repo-settings` e2e testing happy. - There's no point into checking `vertical-align`; it has no effect when `position: absolute` is set, which is is currently set unconditionally for checkboxes and radios on forms. Co-authored-by: Gusted <postmaster@gusted.xyz> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7345 Co-authored-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org> Co-committed-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
42 lines
1.9 KiB
TypeScript
42 lines
1.9 KiB
TypeScript
import {expect, type Page} from '@playwright/test';
|
|
import {accessibilityCheck} from './accessibility.ts';
|
|
|
|
export async function validate_form({page}: {page: Page}, scope: 'form' | 'fieldset' = 'form') {
|
|
const excludedElements = [
|
|
// exclude automated tooltips from accessibility scan, remove when fixed
|
|
'span[data-tooltip-content',
|
|
// exclude weird non-semantic HTML disabled content
|
|
'.disabled',
|
|
// legacy dropdowns don't use semantic HTML yet,
|
|
// avoid using these where possible
|
|
'.ui.dropdown',
|
|
];
|
|
await accessibilityCheck({page}, [scope], excludedElements, []);
|
|
|
|
// assert CSS properties that needed to be overridden for forms (ensure they remain active)
|
|
const boxes = page.getByRole('checkbox').or(page.getByRole('radio'));
|
|
for (const b of await boxes.all()) {
|
|
await expect(b).toHaveCSS('margin-left', '0px');
|
|
await expect(b).toHaveCSS('margin-top', '0px');
|
|
}
|
|
|
|
// assert no (trailing) colon is used in labels
|
|
// might be necessary to adjust in case colons are strictly necessary in help text
|
|
for (const l of await page.locator('label').all()) {
|
|
const str = await l.textContent();
|
|
expect(str.split('\n')[0]).not.toContain(':');
|
|
}
|
|
|
|
// check that multiple help texts are correctly aligned to each other
|
|
// used for example to separate read/write permissions in team permission matrix
|
|
for (const l of await page.locator('label:has(.help + .help)').all()) {
|
|
const helpLabels = await l.locator('.help').all();
|
|
const boxes = await Promise.all(helpLabels.map((help) => help.boundingBox()));
|
|
for (let i = 1; i < boxes.length; i++) {
|
|
// help texts vertically aligned on top of each other
|
|
expect(boxes[i].x).toBe(boxes[0].x);
|
|
// help texts don't horizontally intersect each other
|
|
expect(boxes[i].y + boxes[i].height).toBeGreaterThanOrEqual(boxes[i - 1].y + boxes[i - 1].height);
|
|
}
|
|
}
|
|
}
|