 252efbda5c
			
		
	
	
	252efbda5c
	
	
	
		
			
			After https://github.com/go-gitea/gitea/pull/22385 introduced LFS GC, it never worked due to a bug in the INI library: fields in structs embedded more than one level deep are not populated from the INI file. This PR fixes the issue by replacing the multi-level embedded struct with a single-level struct for parsing the cron.gc_lfs configuration. Added a new test for retrieving cron settings to demonstrate the bug in the INI package. --- Fix #9048 by cherrypicking the fix from Gitea Gitea PR: https://github.com/go-gitea/gitea/pull/35198 Confirmed to work on my own instance, I now see the cron schedule for gc_lfs listed in the site admin menu where it was empty before <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/9202): <!--number 9202 --><!--line 0 --><!--description TEZTIEdDIGlzIG5ldmVyIHJ1bm5pbmcgYmVjYXVzZSBvZiBhIGJ1ZyBpbiB0aGUgcGFyc2luZyBvZiB0aGUgSU5JIGZpbGU=-->LFS GC is never running because of a bug in the parsing of the INI file<!--description--> <!--end release-notes-assistant--> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9202 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Andrew Cassidy <drewcassidy@me.com> Co-committed-by: Andrew Cassidy <drewcassidy@me.com>
		
			
				
	
	
		
			266 lines
		
	
	
	
		
			8.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			266 lines
		
	
	
	
		
			8.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2020 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package cron
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"time"
 | |
| 
 | |
| 	activities_model "forgejo.org/models/activities"
 | |
| 	asymkey_model "forgejo.org/models/asymkey"
 | |
| 	"forgejo.org/models/system"
 | |
| 	user_model "forgejo.org/models/user"
 | |
| 	"forgejo.org/modules/git"
 | |
| 	issue_indexer "forgejo.org/modules/indexer/issues"
 | |
| 	"forgejo.org/modules/setting"
 | |
| 	"forgejo.org/modules/updatechecker"
 | |
| 	moderation_service "forgejo.org/services/moderation"
 | |
| 	repo_service "forgejo.org/services/repository"
 | |
| 	archiver_service "forgejo.org/services/repository/archiver"
 | |
| 	user_service "forgejo.org/services/user"
 | |
| )
 | |
| 
 | |
| func registerDeleteInactiveUsers() {
 | |
| 	RegisterTaskFatal("delete_inactive_accounts", &OlderThanConfig{
 | |
| 		BaseConfig: BaseConfig{
 | |
| 			Enabled:    false,
 | |
| 			RunAtStart: false,
 | |
| 			Schedule:   "@annually",
 | |
| 		},
 | |
| 		OlderThan: time.Minute * time.Duration(setting.Service.ActiveCodeLives),
 | |
| 	}, func(ctx context.Context, _ *user_model.User, config Config) error {
 | |
| 		olderThanConfig := config.(*OlderThanConfig)
 | |
| 		return user_service.DeleteInactiveUsers(ctx, olderThanConfig.OlderThan)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerDeleteRepositoryArchives() {
 | |
| 	RegisterTaskFatal("delete_repo_archives", &BaseConfig{
 | |
| 		Enabled:    false,
 | |
| 		RunAtStart: false,
 | |
| 		Schedule:   "@annually",
 | |
| 	}, func(ctx context.Context, _ *user_model.User, _ Config) error {
 | |
| 		return archiver_service.DeleteRepositoryArchives(ctx)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerGarbageCollectRepositories() {
 | |
| 	type RepoHealthCheckConfig struct {
 | |
| 		BaseConfig
 | |
| 		Timeout time.Duration
 | |
| 		Args    []string `delim:" "`
 | |
| 	}
 | |
| 	RegisterTaskFatal("git_gc_repos", &RepoHealthCheckConfig{
 | |
| 		BaseConfig: BaseConfig{
 | |
| 			Enabled:    false,
 | |
| 			RunAtStart: false,
 | |
| 			Schedule:   "@every 72h",
 | |
| 		},
 | |
| 		Timeout: time.Duration(setting.Git.Timeout.GC) * time.Second,
 | |
| 		Args:    setting.Git.GCArgs,
 | |
| 	}, func(ctx context.Context, _ *user_model.User, config Config) error {
 | |
| 		rhcConfig := config.(*RepoHealthCheckConfig)
 | |
| 		// the git args are set by config, they can be safe to be trusted
 | |
| 		return repo_service.GitGcRepos(ctx, rhcConfig.Timeout, git.ToTrustedCmdArgs(rhcConfig.Args))
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerRewriteAllPublicKeys() {
 | |
| 	RegisterTaskFatal("resync_all_sshkeys", &BaseConfig{
 | |
| 		Enabled:    false,
 | |
| 		RunAtStart: false,
 | |
| 		Schedule:   "@every 72h",
 | |
| 	}, func(ctx context.Context, _ *user_model.User, _ Config) error {
 | |
| 		return asymkey_model.RewriteAllPublicKeys(ctx)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerRewriteAllPrincipalKeys() {
 | |
| 	RegisterTaskFatal("resync_all_sshprincipals", &BaseConfig{
 | |
| 		Enabled:    false,
 | |
| 		RunAtStart: false,
 | |
| 		Schedule:   "@every 72h",
 | |
| 	}, func(ctx context.Context, _ *user_model.User, _ Config) error {
 | |
| 		return asymkey_model.RewriteAllPrincipalKeys(ctx)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerRepositoryUpdateHook() {
 | |
| 	RegisterTaskFatal("resync_all_hooks", &BaseConfig{
 | |
| 		Enabled:    false,
 | |
| 		RunAtStart: false,
 | |
| 		Schedule:   "@every 72h",
 | |
| 	}, func(ctx context.Context, _ *user_model.User, _ Config) error {
 | |
| 		return repo_service.SyncRepositoryHooks(ctx)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerReinitMissingRepositories() {
 | |
| 	RegisterTaskFatal("reinit_missing_repos", &BaseConfig{
 | |
| 		Enabled:    false,
 | |
| 		RunAtStart: false,
 | |
| 		Schedule:   "@every 72h",
 | |
| 	}, func(ctx context.Context, _ *user_model.User, _ Config) error {
 | |
| 		return repo_service.ReinitMissingRepositories(ctx)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerDeleteMissingRepositories() {
 | |
| 	RegisterTaskFatal("delete_missing_repos", &BaseConfig{
 | |
| 		Enabled:    false,
 | |
| 		RunAtStart: false,
 | |
| 		Schedule:   "@every 72h",
 | |
| 	}, func(ctx context.Context, user *user_model.User, _ Config) error {
 | |
| 		return repo_service.DeleteMissingRepositories(ctx, user)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerRemoveRandomAvatars() {
 | |
| 	RegisterTaskFatal("delete_generated_repository_avatars", &BaseConfig{
 | |
| 		Enabled:    false,
 | |
| 		RunAtStart: false,
 | |
| 		Schedule:   "@every 72h",
 | |
| 	}, func(ctx context.Context, _ *user_model.User, _ Config) error {
 | |
| 		return repo_service.RemoveRandomAvatars(ctx)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerDeleteOldActions() {
 | |
| 	RegisterTaskFatal("delete_old_actions", &OlderThanConfig{
 | |
| 		BaseConfig: BaseConfig{
 | |
| 			Enabled:    false,
 | |
| 			RunAtStart: false,
 | |
| 			Schedule:   "@every 168h",
 | |
| 		},
 | |
| 		OlderThan: 365 * 24 * time.Hour,
 | |
| 	}, func(ctx context.Context, _ *user_model.User, config Config) error {
 | |
| 		olderThanConfig := config.(*OlderThanConfig)
 | |
| 		return activities_model.DeleteOldActions(ctx, olderThanConfig.OlderThan)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerUpdateGiteaChecker() {
 | |
| 	type UpdateCheckerConfig struct {
 | |
| 		BaseConfig
 | |
| 		HTTPEndpoint   string
 | |
| 		DomainEndpoint string
 | |
| 	}
 | |
| 	RegisterTaskFatal("update_checker", &UpdateCheckerConfig{
 | |
| 		BaseConfig: BaseConfig{
 | |
| 			Enabled:    true,
 | |
| 			RunAtStart: false,
 | |
| 			Schedule:   "@every 168h",
 | |
| 		},
 | |
| 		HTTPEndpoint:   "https://dl.gitea.com/gitea/version.json",
 | |
| 		DomainEndpoint: "release.forgejo.org",
 | |
| 	}, func(ctx context.Context, _ *user_model.User, config Config) error {
 | |
| 		updateCheckerConfig := config.(*UpdateCheckerConfig)
 | |
| 		return updatechecker.GiteaUpdateChecker(updateCheckerConfig.HTTPEndpoint, updateCheckerConfig.DomainEndpoint)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerDeleteOldSystemNotices() {
 | |
| 	RegisterTaskFatal("delete_old_system_notices", &OlderThanConfig{
 | |
| 		BaseConfig: BaseConfig{
 | |
| 			Enabled:    false,
 | |
| 			RunAtStart: false,
 | |
| 			Schedule:   "@every 168h",
 | |
| 		},
 | |
| 		OlderThan: 365 * 24 * time.Hour,
 | |
| 	}, func(ctx context.Context, _ *user_model.User, config Config) error {
 | |
| 		olderThanConfig := config.(*OlderThanConfig)
 | |
| 		return system.DeleteOldSystemNotices(ctx, olderThanConfig.OlderThan)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| type GCLFSConfig struct {
 | |
| 	BaseConfig
 | |
| 	OlderThan                time.Duration
 | |
| 	LastUpdatedMoreThanAgo   time.Duration
 | |
| 	NumberToCheckPerRepo     int64
 | |
| 	ProportionToCheckPerRepo float64
 | |
| }
 | |
| 
 | |
| func registerGCLFS() {
 | |
| 	if !setting.LFS.StartServer {
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	RegisterTaskFatal("gc_lfs", &GCLFSConfig{
 | |
| 		BaseConfig: BaseConfig{
 | |
| 			Enabled:    false,
 | |
| 			RunAtStart: false,
 | |
| 			Schedule:   "@every 24h",
 | |
| 		},
 | |
| 		// Only attempt to garbage collect lfs meta objects older than a week as the order of git lfs upload
 | |
| 		// and git object upload is not necessarily guaranteed. It's possible to imagine a situation whereby
 | |
| 		// an LFS object is uploaded but the git branch is not uploaded immediately, or there are some rapid
 | |
| 		// changes in new branches that might lead to lfs objects becoming temporarily unassociated with git
 | |
| 		// objects.
 | |
| 		//
 | |
| 		// It is likely that a week is potentially excessive but it should definitely be enough that any
 | |
| 		// unassociated LFS object is genuinely unassociated.
 | |
| 		OlderThan: 24 * time.Hour * 7,
 | |
| 
 | |
| 		// Only GC things that haven't been looked at in the past 3 days
 | |
| 		LastUpdatedMoreThanAgo:   24 * time.Hour * 3,
 | |
| 		NumberToCheckPerRepo:     100,
 | |
| 		ProportionToCheckPerRepo: 0.6,
 | |
| 	}, func(ctx context.Context, _ *user_model.User, config Config) error {
 | |
| 		gcLFSConfig := config.(*GCLFSConfig)
 | |
| 		return repo_service.GarbageCollectLFSMetaObjects(ctx, repo_service.GarbageCollectLFSMetaObjectsOptions{
 | |
| 			AutoFix:                 true,
 | |
| 			OlderThan:               time.Now().Add(-gcLFSConfig.OlderThan),
 | |
| 			UpdatedLessRecentlyThan: time.Now().Add(-gcLFSConfig.LastUpdatedMoreThanAgo),
 | |
| 		})
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerRebuildIssueIndexer() {
 | |
| 	RegisterTaskFatal("rebuild_issue_indexer", &BaseConfig{
 | |
| 		Enabled:    false,
 | |
| 		RunAtStart: false,
 | |
| 		Schedule:   "@annually",
 | |
| 	}, func(ctx context.Context, _ *user_model.User, config Config) error {
 | |
| 		return issue_indexer.PopulateIssueIndexer(ctx)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func registerRemoveResolvedReports() {
 | |
| 	type ReportConfig struct {
 | |
| 		BaseConfig
 | |
| 		ConfigKeepResolvedReportsFor time.Duration
 | |
| 	}
 | |
| 	RegisterTaskFatal("remove_resolved_reports", &ReportConfig{
 | |
| 		BaseConfig: BaseConfig{
 | |
| 			Enabled:    false,
 | |
| 			RunAtStart: false,
 | |
| 			Schedule:   "@every 24h",
 | |
| 		},
 | |
| 		ConfigKeepResolvedReportsFor: setting.Moderation.KeepResolvedReportsFor,
 | |
| 	}, func(ctx context.Context, _ *user_model.User, config Config) error {
 | |
| 		reportConfig := config.(*ReportConfig)
 | |
| 		return moderation_service.RemoveResolvedReports(ctx, reportConfig.ConfigKeepResolvedReportsFor)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func initExtendedTasks() {
 | |
| 	registerDeleteInactiveUsers()
 | |
| 	registerDeleteRepositoryArchives()
 | |
| 	registerGarbageCollectRepositories()
 | |
| 	registerRewriteAllPublicKeys()
 | |
| 	registerRewriteAllPrincipalKeys()
 | |
| 	registerRepositoryUpdateHook()
 | |
| 	registerReinitMissingRepositories()
 | |
| 	registerDeleteMissingRepositories()
 | |
| 	registerRemoveRandomAvatars()
 | |
| 	registerDeleteOldActions()
 | |
| 	registerUpdateGiteaChecker()
 | |
| 	registerDeleteOldSystemNotices()
 | |
| 	registerGCLFS()
 | |
| 	registerRebuildIssueIndexer()
 | |
| 	if setting.Moderation.Enabled {
 | |
| 		registerRemoveResolvedReports()
 | |
| 	}
 | |
| }
 |